[Piglit] [PATCH 06/12] glx_arb_create_context: Verify that the invalid GL versions are rejected

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/14/2011 10:47 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> NVIDIA's closed-source driver passes this test.
> 
> AMD's closed-source driver fails this test because it does not
> generate any GLX error.  It correctly does not create the context.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/all.tests                                    |    1 +
>  .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
>  .../glx_arb_create_context/invalid-gl-version.c    |  106 ++++++++++++++++++++
>  3 files changed, 108 insertions(+), 0 deletions(-)
>  create mode 100644 tests/spec/glx_arb_create_context/invalid-gl-version.c

I wondered why you didn't test for rejection of the forward-compaitble flag with
a pre-3.0 version. But, I see that that test comes in a later patch.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO8OXCAAoJEAIvNt057x8ixScQAImRzMMVeE6QnZeuSedlXXk8
KqZ/ZYESvBbbEZGClpcEmDRWbh/wJ4blTmzCifY1b+RUeRG2UYA0Gc9hn8AW7P87
TElIUBhtxxD8wzISajVApis4o5lq5ugVMeoYHjhqBQ8mbMrEz+TQExQWOsnlR92g
66/TDuZJoGVbl0rprVtsCp6aZB0+AifXbBhlCUihwJZmJikv9+1YwUKlZkDJ4p1U
yZ8Sfgpap4t0PHvwB5s2poEPZHl6KBThpTI4/hHvkOE6E9mqZazKAIM1TUCM9e+0
3XD8XaK2GeLwBoaYey0XUZfbpO9fRBld1+cYN7gX9gxvXcK3LYl3lmStNEwqkvq3
4+bfnPxUon6ddbwX8jXHAgVXMvxoPABShXk6mPq0/9xlSLtB04WdiqE9j+lZ8LeX
QuPtow0TVYk5pbBaOH3/luvwlLe7SiDpZYGY1bKOjwv1ayzB5b5gbzT8vNnj5jsr
ECsQC6W+PupLT5rfr4/MBEx0HGB3fs//ebdGYFBhjm8sv4M7LoWagW3PXmp+rkp6
CL1UPIBU9TncPntw2Gz3j1ZyZrLHCymQS+2oRXTQtNkXIaMfaFp8SWHca9PFhcA+
l7Vjy+eKlyeEM9FvBvBwLPitdql+V2NXULasReYh4UDwsKTPMEFxAPisWNDPWY8W
qOjii+rNNRxcbvaXyGre
=mCtI
-----END PGP SIGNATURE-----