[Piglit] [PATCH 02/12] glx_arb_create_context: Verify default major version is 1

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/14/2011 10:47 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Both AMD's and NVIDIA's closed-source drivers pass this test.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  tests/all.tests                                    |    1 +
>  .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
>  .../glx_arb_create_context/default-major-version.c |   80 ++++++++++++++++++++
>  3 files changed, 82 insertions(+), 0 deletions(-)
>  create mode 100644 tests/spec/glx_arb_create_context/default-major-version.c



> +	/* The GLX_ARB_create_context spec says:
> +	 *
> +	 *     "The default values for GLX_CONTEXT_MAJOR_VERSION_ARB and
> +         *     GLX_CONTEXT_MINOR_VERSION_ARB are 1 and 0 respectively. In this
> +         *     case, implementations will typically return the most recent
> +         *     version of OpenGL they support which is backwards compatible
> +         *     with OpenGL 1.0 (e.g. 3.0, 3.1 + GL_ARB_compatibility, or 3.2
> +         *     compatibility profile)."

Indentation issues here. I wish the world could agree to never use hard tabs. Then silly
mistakes like this would not happen.

Other than that:
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO8OXQAAoJEAIvNt057x8i7c0QAIKB3kvkw5Mp73yUlp5Rq4wq
msvLT2/ZUI+duTFgbtSHvAiKRhA9YJ/W/0gdOhXjnN3R/kxb69kNWPjmstsKUQSs
nxrD7wtCFLhaihws6PiKY43RWPzCKMs61NFqI5vytCq3b0pHwjUEULZMuTBrJCyA
y2EnM3VngZXRm8Pn2iuR4y0Dexow9p7AJ/jvehhy+CUIt+WE3um9+YSkKMZbz7qK
AJjTaM/r4QV0HTtlb72nl6e/f2lfYg/6OrZXz2vRc4/UxtOoJh7h/DIC5yJVCJac
62YP41DnW2Y2SCr4tWURUZvkr5k+T8sI3kHb3pWI/VTl+DBKQXTOKBMRN7CrwRaw
LikiPmcH3ABY5XGG02P96jeIzegquS+MQNWuMnahERTDWmHn6N0LN8SOB4kyWtDC
mv0dXlSVH7i9hYotl4eaxTkyr/TyLARRFAqeEkrH2hlIMbOBsf1bxjFI6GMEMVpL
+k9n4UYD0Y/DbWBATuLEe7UneejSigb50OSWMSr86boAZZB9RJJKuReYm2bmB8qN
DwUE3iIyZF5LOLro7BhM8GEV6TUO1YPQ3dTZcHgF+NESBB6headbN6r3vB+L0B2w
8tW602LXcXCFEyFpjEAM30vlqCegPWqfKmmPrOvbHfDgsTgMMQXreSwbtF5Uh57X
vAPJKOGUKHqIGWWFK5iO
=6ZCL
-----END PGP SIGNATURE-----