[Piglit] [PATCH 2/2] Test transform feedback with max varyings.

[Eric Anholt]

On Thu, 22 Dec 2011 07:41:31 -0800, Paul Berry <stereotype441 at gmail.com> wrote:
> This patch modifies the existing test glsl-max-varyings so that if the
> "xfb" option is supplied, it uses transform feedback to verify
> correct varying values (in addition to using them for rendering).
> This verifies that transform feedback truly supports all the varyings
> claimed by GL_MAX_TRANSFORM_FEEDBACK_INTERLEAVED_COMPONENTS.
> 
> The old behavior (without the "xfb" flag) is retained so that
> glsl-max-varyings is still a worthwhile test on implementations that
> do not support transform feedback.
> 
> Verified on the nVidia proprietary Linux driver and Mesa i965 Sandy
> Bridge.

I think I'd rather see this version of the test forked off to a new
file, since it's adding half again the original code.

Oh, god, that string handling is awful, though.  I'm embarassed, as
usual.  We could also drop a little bit of code by replacing the
green/red attributes with uniforms.

> ---
>  tests/all.tests                   |    1 +
>  tests/shaders/glsl-max-varyings.c |  139 +++++++++++++++++++++++++++++++++++-
>  2 files changed, 136 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/all.tests b/tests/all.tests
> index 012de96..0390cbc 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -426,6 +426,7 @@ add_plain_test(shaders, 'glsl-fs-texturelod-01')
>  add_plain_test(shaders, 'glsl-fs-user-varying-ff')
>  add_plain_test(shaders, 'glsl-mat-attribute')
>  add_plain_test(shaders, 'glsl-max-varyings')
> +shaders['glsl-max-varyings xfb'] = PlainExecTest(['glsl-max-varyings', 'xfb', '-auto'])
>  add_plain_test(shaders, 'glsl-orangebook-ch06-bump')
>  add_plain_test(shaders, 'glsl-routing')
>  add_plain_test(shaders, 'glsl-vs-arrays')

(oh, and this could go under EXT_transform_feedback, right?)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111227/138fa22f/attachment.pgp>