[Piglit] [PATCH 4/7] Modify the Test class in core.py to use ThreadPools.

Chad Versace chad at chad-versace.us
Mon Feb 7 16:24:09 PST 2011


Oops. Ignore my comment here. I misunderstood this hunk.

On 02/07/2011 02:22 PM, Chad Versace wrote:
> On 02/07/2011 12:04 PM, U. Artie Eoff wrote:
> 
>> @@ -380,6 +387,7 @@ class TestProfile:
>>  	def run(self, env):
>>  		time_start = time.time()
>>  		self.tests.doRun(env, '')
>> +		ThreadPools().joinAll()
>>  		time_end = time.time()
>>  		print >>env.file, "time:",(time_end-time_start)
>>
> 
> The timestamp should be taken immediately after the test has completed
> and before the thread joins the pool. That is,
> 
>>  	def run(self, env):
>>  		time_start = time.time()
>>  		self.tests.doRun(env, '')
>> -		ThreadPools().joinAll()
>>  		time_end = time.time()
>> +		ThreadPools().joinAll()
>>  		print >>env.file, "time:",(time_end-time_start)
>>
> 
> 

-- 
Chad Versace
chad at chad-versace.us


More information about the Piglit mailing list