[Piglit] [PATCH 6/7] Add SyncFileWriter for write/close synchronization on results file.

Eoff, Ullysses A ullysses.a.eoff at intel.com
Mon Feb 7 17:49:09 PST 2011



> -----Original Message-----
> From: Chad Versace [mailto:chadversace at gmail.com] On Behalf Of Chad
> Versace
> Sent: Monday, February 07, 2011 3:04 PM
> To: Eoff, Ullysses A; pig >> "piglit at lists.freedesktop.org"
> Subject: Re: [Piglit] [PATCH 6/7] Add SyncFileWriter for write/close
> synchronization on results file.
> 
> On 02/07/2011 12:04 PM, U. Artie Eoff wrote:
> > +	from framework.threads import synchronized_self
> > +	class SyncFileWriter:
> 
> It feels awkward for this import and class definition to exist at
> function scope rather than module scope. Please move them outside the
> definition of main().

I agree.  I defined it here initially to get things working and then
Forgot to move it.

> --
> Chad Versace
> chad at chad-versace.us


More information about the Piglit mailing list