[Piglit] [PATCH 4/7] Modify the Test class in core.py to use ThreadPools.

Eoff, Ullysses A ullysses.a.eoff at intel.com
Mon Feb 7 17:59:43 PST 2011



> -----Original Message-----
> From: Chad Versace [mailto:chadversace at gmail.com] On Behalf Of Chad
> Versace
> Sent: Monday, February 07, 2011 3:00 PM
> To: Eoff, Ullysses A; piglit at lists.freedesktop.org
> Subject: Re: [Piglit] [PATCH 4/7] Modify the Test class in core.py to
> use ThreadPools.
> 
> Please remove the trailing whitespace here.
> 
> >  	def doRun(self, env, path):
> > +		if ThreadPools().lookup(self.poolName) is None:
> > +			ThreadPools().create(self.poolName)
> > +		ThreadPools().put(self.__doRunWork, args = (env, path,),
> name = self.poolName)
> > + TRAILING WHITESPACE HERE
> > +	def __doRunWork(self, env, path):
> 
> The best way to prevent whitespace from creeping into your commits is
> to
> enable the default Git pre-commit hook.
> 
> cd path/to/repo/.git/hooks
> mv pre-commit.sample pre-commit
> chmod +x pre-commit
> 

Yes, thanks for catching this.  I usually have my editor setup to remove
trailing spaces but must have forgot to do this on my new installation.
I'll enable the pre-commit hook, too.  Thanks for the advice.

> --
> Chad Versace
> chad at chad-versace.us


More information about the Piglit mailing list