[Piglit] [PATCH 1/4] Add ConcurrentTestPool singleton.

Ian Romanick idr at freedesktop.org
Mon Feb 14 13:33:48 PST 2011

Hash: SHA1

On 02/12/2011 12:36 PM, Eoff, Ullysses A wrote:
> These patches restore ctrl-c behavior for the GPU tests while executing
> the cpu-only tests concurrently.  However, there is still one exception
> right now:
> the glslparsertests do not get queued into the threadpool until
> after some of the GPU tests run.  This is attributed to the alphabetical
> sorting of the tests before they are iterated over for doWork execution.
> For example, "glean" tests will run one-by-one on the main thread before
> "glslparser" tests are even encountered for concurrent queuing.
> I will submit a follow-up patch that fixes this.  Most likely it'll just
> sort the tests based on the "runConcurrent" flag prior to iterating over
> them so that concurrent queuing is handled first.  Hopefully it's as
> simple as that :)

I don't think I'd even bother.  There are basically 3 ways that most
people use piglit:

1. Run all of the tests to check for regressions.

2. Run a small subset of GPU tests while developing a new feature,
trying to fix a specific bug, etc.

3. Run all or a subset of the parser tests while working on the compiler.

As it is, I'm sure that in #1 all of the non-GPU tests are done long
before the GPU tests.  In the other cases it won't matter anyway.
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/


More information about the Piglit mailing list