[Piglit] [PATCH 1/2] glsl-1.20: Add serveral tests for recursion in shaders

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have one correction.

On 07/08/2011 03:32 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
[snip]
> +/**
> + * \file glsl-recursion.c
> + * Verify that shaders containing static recursion are rejected.
> + *
> + * From page 44 (page 50 of the PDF) of the GLSL 1.20 spec:
> + *
> + *     "Recursion is not allowed, not even statically. Static recursion is
> + *     present if the static function call graph of the program contains
> + *     cycles."
> + *
> + * This langauge leaves a lot of questions unanswered.
> + *
> + *     - Is the error generated at compile-time or link-time?
> + *
> + *     - Is it an error to have a recursive function that is never statically
> + *       called by main or any function called directly or indirectly by main?
> + *       Technically speaking, such a function is not in the "static function
> + *       call graph of the program" at all.
> + *
> + * This set of tests checks for a variety of forms of recursion in shaders.
> + * Errors are checked at both compile-time and link-time.
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The comment needs correction. Compilation failure is never checked; only link
failure is checked. Perhaps this was meant to say that the info log of each stage
is printed?

> + *
> + * \author Ian Romanick <ian.d.romanick at intel.com>
> + */

Other than the misleading comment, all looks good.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOHOvdAAoJEAIvNt057x8iivEP/0zgU7Amjn3cGTsnGjPVacdI
AcrzW0WvFtSPt8ZYGSMYkIDiY6sso2oGLIRqxdouRYrBe16hR5qaA6RADdt1aYBE
gdFmZe4To+w6jW7YTFglegOeIyUJMjKkgzfHv2g0+BYDv5DA/0kU8zoxfBhIZDCA
Eby+x9r3bqK9r4PJtGERrr4zUxk6tJvp57dilrUCIMKZR6rhxR8yy3vTr/KMJuAr
RKfZ+mcyazmM5Rl58LLQjU4atrdzCX5O1F3yEFwmhw2m078ALSdNayml0iVXSyZO
4DBa+36Gk60Wm4z7ZnOGnq/iC+OKntLGk6zSRLN3LqvWETSVWTWo8UjfOAQy/TSz
NO9j2NCvjzH7kaSQ8Pl0PFRZ3FrnKxV40cBKtYMjmWUmN5x3oWewQOyp6nNUhXOj
42cxm97+/T84ztQ7pLeG4zK4m/ubO6NFPr9cdROAWC/otIj9Ag1Uu9bwNyDbce8m
vV7uzosJbXKgmgcFvO11ZrFyshxpY8qflBTGCFoythgQDc1Jnugm1G8lpVrrU1Vn
7wVASjpIrAiPG/+J0XMc53rau2Dn4TYQqMIzOW5kS1e27QGU/bXPJ0nt9AleL028
4dHip7wpmsi8NJ6p33Xp1O/LgbjJp7cJXXPk7IzVcNwWUvZaNRUt95ilNNMpAfrO
wwR3ZCUv9alajKO9a3Cm
=IS0m
-----END PGP SIGNATURE-----