[Piglit] [PATCH 1/2] arb_es2_compatibility: Verify clearing FBO with missing color doesn't crash
Ian Romanick
idr at freedesktop.org
Thu Jun 2 14:13:03 PDT 2011
From: Ian Romanick <ian.d.romanick at intel.com>
The relaxed completeness rules in ARB_ES2_compatibility allow clearing
the color buffer of an FBO that lacks a color attachment and has the
draw buffer set to non-GL_NONE.
Reproduces Mesa bugzilla #37739.
---
tests/all.tests | 1 +
tests/spec/arb_es2_compatibility/CMakeLists.gl.txt | 2 +-
.../fbo-missing-attachment-clear.c | 115 ++++++++++++++++++++
3 files changed, 117 insertions(+), 1 deletions(-)
create mode 100644 tests/spec/arb_es2_compatibility/fbo-missing-attachment-clear.c
diff --git a/tests/all.tests b/tests/all.tests
index ce4db12..a723ada 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -714,6 +714,7 @@ add_plain_test(arb_es2_compatibility, 'arb_es2_compatibility-maxvectors')
add_plain_test(arb_es2_compatibility, 'arb_es2_compatibility-shadercompiler')
add_plain_test(arb_es2_compatibility, 'arb_es2_compatibility-releaseshadercompiler')
add_plain_test(arb_es2_compatibility, 'arb_es2_compatibility-fixed-type')
+add_plain_test(arb_es2_compatibility, 'fbo-missing-attachment-clear')
# Group ARB_draw_instanced
arb_draw_instanced = Group()
diff --git a/tests/spec/arb_es2_compatibility/CMakeLists.gl.txt b/tests/spec/arb_es2_compatibility/CMakeLists.gl.txt
index 1529e15..e8c3d5c 100644
--- a/tests/spec/arb_es2_compatibility/CMakeLists.gl.txt
+++ b/tests/spec/arb_es2_compatibility/CMakeLists.gl.txt
@@ -21,5 +21,5 @@ add_executable (arb_es2_compatibility-releaseshadercompiler arb_es2_compatibilit
add_executable (arb_es2_compatibility-shadercompiler arb_es2_compatibility-shadercompiler.c)
add_executable (arb_es2_compatibility-getshaderprecisionformat arb_es2_compatibility-getshaderprecisionformat.c)
add_executable (arb_es2_compatibility-fixed-type arb_es2_compatibility-fixed-type.c)
-
+add_executable (fbo-missing-attachment-clear fbo-missing-attachment-clear.c)
# vim: ft=cmake:
diff --git a/tests/spec/arb_es2_compatibility/fbo-missing-attachment-clear.c b/tests/spec/arb_es2_compatibility/fbo-missing-attachment-clear.c
new file mode 100644
index 0000000..43b2ec9
--- /dev/null
+++ b/tests/spec/arb_es2_compatibility/fbo-missing-attachment-clear.c
@@ -0,0 +1,115 @@
+/*
+ * Copyright © 2011 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file fbo-missing-attachment-clear.c
+ * Verify that a color clear on a depth-only FBO doesn't crash
+ *
+ * From the ARB_ES2_compatibility spec:
+ *
+ * (8) How should we handle draw buffer completeness?
+ *
+ * RESOLVED: Remove draw/readbuffer completeness checks, and treat
+ * drawbuffers referring to missing attachments as if they were NONE.
+ *
+ * It is valid to have a depth-only FBO that has the draw buffer set to values
+ * other than \c GL_NONE. However, doing operations that would read from or
+ * draw to these missing attachments should treat them as though they were
+ * \c GL_NONE (i.e., don't crash).
+ *
+ * See also https://bugs.freedesktop.org/show_bug.cgi?id=37739.
+ *
+ * \author Ian Romanick <ian.d.romanick at intel.com>
+ */
+#include "piglit-util.h"
+
+int piglit_width = 32;
+int piglit_height = 32;
+int piglit_window_mode = GLUT_RGB;
+
+enum piglit_result
+piglit_display(void)
+{
+ return PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ GLuint tex;
+ GLuint fb;
+ GLenum status;
+ GLenum err;
+ bool pass;
+
+ piglit_require_extension("GL_ARB_framebuffer_object");
+ piglit_require_extension("GL_ARB_ES2_compatibility");
+
+ /* Create a depth-only FBO.
+ */
+ glGenTextures(1, &tex);
+ glBindTexture(GL_TEXTURE_2D, tex);
+ glTexImage2D(GL_TEXTURE_2D, 0, GL_DEPTH_COMPONENT, 32, 32, 0,
+ GL_DEPTH_COMPONENT, GL_FLOAT, NULL);
+
+ glGenFramebuffers(1, &fb);
+ glBindFramebuffer(GL_FRAMEBUFFER, fb);
+ glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT,
+ GL_TEXTURE_2D, tex, 0);
+
+ err = glGetError();
+ if (err != 0) {
+ fprintf(stderr, "Unexpected GL error state 0x%04x\n", err);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
+ if (status != GL_FRAMEBUFFER_COMPLETE) {
+ fprintf(stderr, "FBO erroneously incomplete: 0x%04x\n",
+ status);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ /* Clear the depth buffer to a known value.
+ */
+ printf("Clearing depth buffer to 0.0...\n");
+ glClearDepth(0.0);
+ glClear(GL_DEPTH_BUFFER_BIT);
+ pass = piglit_probe_rect_depth(0, 0, piglit_width, piglit_height, 0.0);
+
+ /* Clear the depth buffer and the color buffer to different values.
+ */
+ printf("Clearing depth buffer to 0.5...\n");
+ glClearDepth(0.5);
+ glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
+ pass = piglit_probe_rect_depth(0, 0, piglit_width, piglit_height, 0.5)
+ && pass;
+
+ err = glGetError();
+ if (err != 0) {
+ fprintf(stderr, "Unexpected GL error state 0x%04x\n", err);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
--
1.7.4
More information about the Piglit
mailing list