No subject


Thu Jun 9 11:16:29 PDT 2011


----
Chad Versace
 
> >> Without knowing that the spec declares singlebuffering to be the
> >> default, or spending two minutes to look it up in the spec, it's not evident that
> >> the test actually tests a singlebuffered drawable.
> >>
> >> With that,
> >> Reviewed-by: Chad Versace<chad at chad-versace.us>
> >>
> >> I've never used pixmaps, so I can't effectively review patch 2.
> >
> > I'm confused about GLX_DOUBLEBUFFER usage, looking at our
> > tests. glx-swap-exchange, glx-close-display, and
> > glx-make-current-bad-context all seem to be not providing an argument
> > for GLX_DOUBLEBUFFER -- the end-of-list sentinel immediately follows
> > them in 2 cases.
> 
> Right.  We just always need to keep in mind whether we're using 
> glXChooseVisual or glXChooseFBConfig.
> 
> -Brian


More information about the Piglit mailing list