[Piglit] [PATCH] new test : glsl-max-vertex-attrib.c
Brian Paul
brian.e.paul at gmail.com
Mon May 23 07:06:06 PDT 2011
On Mon, May 23, 2011 at 12:06 AM, <tapani.palli at intel.com> wrote:
> From: Tapani Pälli <tapani.palli at intel.com>
>
> Queries the value for GL_MAX_VERTEX_ATTRIBS and uses that as index
> to set a value. GL specification states that GL_INVALID_VALUE should
> occur if index >= GL_MAX_VERTEX_ATTRIBS.
Some comments:
It would be good if the test exercised all the glVertexAttrib()
functions instead of just one of them. Also, test
glVertexAttribPointer() and other functions that do index checking
against GL_MAX_VERTEX_ATTRIBS.
Finally, the indentation is inconsistent. There's unused variables.
There's left-over debug code in the shader. Maybe you could clean
that up too. Thanks.
-Brian
More information about the Piglit
mailing list