[Piglit] [PATCH 1/2] arb_color_buffer_float/render: refactor code for easier debugging

[Eric Anholt]

On Sun, 2 Oct 2011 16:34:25 -0600, Brian Paul <brian.e.paul at gmail.com> wrote:
> On Sat, Oct 1, 2011 at 10:03 PM, Eric Anholt <eric at anholt.net> wrote:
> > On Wed, 28 Sep 2011 14:13:14 -0600, Brian Paul <brianp at vmware.com> wrote:
> >> If you have to debug a failing case in this test it's now a simple
> >> matter to add a new call to test_one() passing just the parameters
> >> you're interested in.
> >> -             if (test_fog && fpmode)
> >> -             {
> >> -                     //printf("Unclear specification on GL_ARB_fog_*\n");
> >> -                     opass = GL_TRUE;
> >> +             else {
> >> +                     printf("Re-running failed test\n");
> >> +                     pass = test_one(vert_clamp, frag_clamp, semantic,
> >> +                                     blend, logicop, vpmode, fpmode);
> >>               }

> >>       printf("Summary: %i/%i passed.\n", npass, total);
> >> -     return pass;
> >> +     return all_pass;
> >
> > So, if the test intermittently fails, we'll end up not reporting that as
> > failure if it's not immediately reproduced?  That seems bad.
> 
> I'm not sure follow what you mean.  I only rearranged the code to make
> it bit more debug-able.  AFAICT, I didn't change it's behavior.  I'll
> double-check tomorrow though.

I don't see the "Re-running failed test" part before.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111003/f97cd199/attachment.pgp>