[Piglit] [PATCH 4/4] fbo-drawbuffers: Port to ES2 w/NV_draw_buffers and NV_fbo_color_attachments

[Eric Anholt]

On Tue, 04 Oct 2011 13:59:33 -0700, Ian Romanick <idr at freedesktop.org> wrote:
> On 10/04/2011 01:39 PM, Eric Anholt wrote:
> > On Mon,  3 Oct 2011 11:40:24 -0700, "Ian Romanick"<idr at freedesktop.org>  wrote:
> >> From: Ian Romanick<ian.d.romanick at intel.com>
> >>
> >> Signed-off-by: Ian Romanick<ian.d.romanick at intel.com>
> >> ---
> >>   tests/fbo/CMakeLists.gles2.txt |   11 +++++
> >>   tests/fbo/fbo-drawbuffers.c    |   83 +++++++++++++++++++++++++++++++++++++++-
> >>   2 files changed, 93 insertions(+), 1 deletions(-)
> >>   create mode 100644 tests/fbo/CMakeLists.gles2.txt
> >
> > So, 83 lines out of a 138-line test (counting copyright header) just to
> > share code?  I think a separate test would have been better here.
> 
> That's fair.  All of the extra code comes from having both GLSL (for 
> ES2) and fixed-function (for desktop) paths.  The other option would be 
> to make the test always use GLSL.  I don't know of any hardware that 
> supports MRT and doesn't support GLSL.
> 
> I'd actually prefer to do that.

Works for me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111004/f08815e2/attachment.pgp>