[Piglit] [PATCH] fbo-generatemipmap-formats: fix drawing/testing of mipmaps

Eric Anholt eric at anholt.net
Tue Oct 11 11:29:07 PDT 2011


On Mon, 10 Oct 2011 20:29:28 +0200, Marcin Slusarz <marcin.slusarz at gmail.com> wrote:
> On Mon, Oct 10, 2011 at 09:54:32AM -0700, Eric Anholt wrote:
> > On Sun, 9 Oct 2011 23:48:35 +0200, Marcin Slusarz <marcin.slusarz at gmail.com> wrote:
> > > It started with level 0 covering whole texture and then drawed
> > > behind texture border, which lead to random test failures.
> > 
> > I can't follow what you're trying to fix here.
> 
> It's probably easier to apply attached patch and watch the results,
> instead of explaining each line changed...

Just to humor you, I ran with the patch, and it printed "wtf" with
values that are exactly what I expected the values to be.

You really need to answer the questions for me to understand what you're
trying to fix and why your change is the correct fix.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111011/f080cc94/attachment.pgp>


More information about the Piglit mailing list