[Piglit] [PATCH 07/13] Make a plain_test() helper like concurrent_test() vs add_concurrent_test().

Paul Berry stereotype441 at gmail.com
Mon Oct 17 10:15:42 PDT 2011


On 15 October 2011 13:19, Eric Anholt <eric at anholt.net> wrote:

> ---
>  framework/exectest.py |    3 ---
>  tests/all.tests       |    6 ++++++
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/framework/exectest.py b/framework/exectest.py
> index a22fe86..5821071 100644
> --- a/framework/exectest.py
> +++ b/framework/exectest.py
> @@ -119,9 +119,6 @@ class ExecTest(Test):
>
>
>
> -def add_plain_test(group, name):
> -       group[name] = PlainExecTest([name, '-auto'])
> -
>
>  #############################################################################
>  ##### PlainExecTest: Run a "native" piglit test executable
>  ##### Expect one line prefixed PIGLIT: in the output, which contains a
> diff --git a/tests/all.tests b/tests/all.tests
> index e095e2c..d7d1e11 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -25,6 +25,12 @@ generatedTestDir = os.path.join(
>        'generated_tests')
>
>  # Quick wrapper for PlainExecTest for our usual concurrent args.
> +def plain_test(name):
> +       return PlainExecTest([name, '-auto'])
> +
> +def add_plain_test(group, name):
> +       group[name] = PlainExecTest([name, '-auto'])
> +
>

Did you mean to do this?

def add_plain_test(group, name):
    group[name] = plain_test(name)


>  def concurrent_test(args):
>        test = PlainExecTest(args + " -auto -fbo")
>        test.runConcurrent = True
> --
> 1.7.7
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111017/e56ea709/attachment.htm>


More information about the Piglit mailing list