[Piglit] [PATCH] fbo-generatemipmap-array: Remove fixed-function operations.

Eric Anholt eric at anholt.net
Sun Oct 23 00:43:49 PDT 2011


On Thu, 20 Oct 2011 16:45:48 -0700, Vinson Lee <vlee at vmware.com> wrote:
> The EXT_texture specification does not support fixed-function for
> TEXTURE_[12]D_ARRAY_EXT.
> 
> Fixes GL_INVALID_ENUM errors on Mac OS X with
> glEnable(GL_TEXTURE_[12]D_ARRAY_EXT).
> ---
>  tests/fbo/fbo-generatemipmap-array.c |   12 ------------
>  1 files changed, 0 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/fbo/fbo-generatemipmap-array.c b/tests/fbo/fbo-generatemipmap-array.c
> index 12c9e30..aaa8a60 100644
> --- a/tests/fbo/fbo-generatemipmap-array.c
> +++ b/tests/fbo/fbo-generatemipmap-array.c
> @@ -257,14 +257,8 @@ draw_mipmap_2d(int x, int y, int dim, int layer)
>  
>  	glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0);
>  
> -	glEnable(GL_TEXTURE_2D_ARRAY_EXT);
> -	glTexEnvi(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_REPLACE);
> -	glTexParameteri(GL_TEXTURE_2D_ARRAY_EXT, GL_TEXTURE_MIN_FILTER, GL_NEAREST_MIPMAP_NEAREST);
> -	glTexParameteri(GL_TEXTURE_2D_ARRAY_EXT, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
> -

By dropping the TexParameters, you've changed the filtering from
NEAREST_MIPMAP_NEAREST/NEAREST to NEAREST_MIPMAP_LINEAR/LINEAR.  I don't
think we want that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111023/eae0c253/attachment.pgp>


More information about the Piglit mailing list