[Piglit] [PATCH 0/6] Clean up GLSL linker tests

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/28/2011 03:26 PM, Ian Romanick wrote:
> The first two patches replace a pile of C code tests with a simple
> test framework for linker tests.  A list of shaders and a pass / fail
> result is passed to glsl-link-test.  The test passes if linking
> produces the expected result.
> 
> Patch 3/6 makes an exist test expect the behavior mandated by the GLSL
> 4.20 spec.  The previous behavior was, basically, unimplementable.
> 
> Patches 4/6 and 5/6 add a couple new variations.
> 
> Patch 6/6 simplifies one of the existing tests.

Finally, we have an expedient way to write linker tests.

My only real concern is that, to add a test to all.tests, one must list all
the shaders and the expected result. This doesn't scale well and becomes messy
quickly. I recall the pain of the big cleanup I did for parser tests. But,
that said, this series is expedient and gets the job done.

Comments on patches 1 and 2.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOru4RAAoJEAIvNt057x8i2I4P/1vP24QMF4u3elmlRWEvN7vR
er18y4mqB84dkzsySMLbfPppfLcAmX6BpgGw8Y2WMCdtXtEOVM8TGCF4G12lCrsn
R7EOkAs9Ci/n0aFZu7Tum7/qX4mVRrYHThkpysx69T1lW0xBH8VT2Zado4H09EF9
N0FSGNtQoq0vyNwCkV2S2hLJuql9OfAEjv1i3xlNLWnr/InxbWxvEHNKnVsmeu/F
7BJpG3Ketw4jRBkFgG7uIBAzJRShFNk5UWRwJ6qcLppDCmnx+7XXa/BUdKXtOnnH
8RiaQPx4RazrAlWdPMECJR1oZ7sm1REWG2nXkLNvEPxiw7280Uo8Wv7t/VXXf9o9
urSPixS8Scp0b8G1dn8VaXw98PlF77qLJl7Gulmk7POK5yRMRTV17qTx/IM20hc4
I4KXLvjQoIvHr2GIZfSTNRfF4iwEPRs53igf7WXQPr0PccjqoJOICllqElboZ1ob
gdE3KJy4zz0o09DbX1IN6j0hP06s5xQrtGc6FD9wHJ0jwnio4q2t3xrBAQ5fWdE0
gdi8CB/0Z30CXqDDTgiXjo9lLV2RWD5G3Lw4196UiaZB2fbjTO51S92b0ENQIp7g
JP1sOcPZKJbZldl+4A9g6mwT5k4g5cwHg+FXmB88qo7ihjhpvCmRSyqCPergK10S
Am//ZyiUs86RBvoS4TUl
=u0AG
-----END PGP SIGNATURE-----