[Piglit] [PATCH 0/8] add infrastructure for GLES1 tests

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/03/2011 09:29 AM, Chia-I Wu wrote:
> This series adds the cmake infrastructure to write GLES1 tests.  Most
> of it are about rearranging sources for piglitutil so that they can be
> compiled against GLES1 headers.
> 
> Patch 1 is not strictly part of this series, but it fixes a compile
> error on my machine.  Patch 2-4 move the code in piglitutil around,
> in preparation for GLES1 support.
> 
> Patch 5-7 add GLES1 support to piglitutil and the last patch adds the
> cmake changes.  I am not very certain about patch 6.  It adds
> piglit-util-gles1.c to piglitutil, which includes piglit-util-gles2.c!
> I am not sure if that is a good practice.  It might be better to
> rename piglit-util-gles2.c to piglit-util-gles.c and let
> libpiglitutil_gles{1,2}.a share it.

I sent some review comments for 6/8 and 7/8.  The comments about
piglit_get_gl_error_name in 6/8 are probably applicable to 1/8 as well.
 Other than that, 2/8, 3/8, 4/8, 5/8, and 8/8 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Thanks for tacking this, BTW.  I wasn't looking forward to doing it
myself...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5kGKsACgkQX1gOwKyEAw/guwCeK9X6msDbURQcpGnO4OIk6yRI
NE0AoJdrEHBkQzyEQWH1WvhEn54/Bcgo
=EAww
-----END PGP SIGNATURE-----