[Piglit] [PATCH 10/11] egl_khr_create_context: Verify that the invalid flags are rejected

[Ian Romanick]

On 07/31/2012 06:38 PM, Matt Turner wrote:
> ---
>   tests/all_egl.tests                                |    1 +
>   .../spec/egl_khr_create_context/CMakeLists.gl.txt  |    1 +
>   .../egl/spec/egl_khr_create_context/invalid-flag.c |   83 ++++++++++++++++++++
>   3 files changed, 85 insertions(+), 0 deletions(-)
>   create mode 100644 tests/egl/spec/egl_khr_create_context/invalid-flag.c
>
> diff --git a/tests/all_egl.tests b/tests/all_egl.tests
> index db5cd44..a8293bf 100644
> --- a/tests/all_egl.tests
> +++ b/tests/all_egl.tests
> @@ -26,3 +26,4 @@ create_context['valid attribute empty'] = plain_test(['egl-create-context-valid-
>   create_context['NULL valid attribute'] = plain_test(['egl-create-context-valid-attribute-null'])
>   create_context['invalid OpenGL version'] = plain_test(['egl-create-context-invalid-gl-version'])
>   create_context['invalid attribute'] = plain_test(['egl-create-context-invalid-attribute'])
> +create_context['invalid flag'] = plain_test(['egl-create-context-invalid-flag'])
> diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> index 0b03b3c..8e3a457 100644
> --- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> +++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> @@ -17,5 +17,6 @@ piglit_add_executable (egl-create-context-valid-attribute-empty valid-attribute-
>   piglit_add_executable (egl-create-context-valid-attribute-null valid-attribute-null.c common.c)
>   piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
>   piglit_add_executable (egl-create-context-invalid-attribute invalid-attribute.c common.c)
> +piglit_add_executable (egl-create-context-invalid-flag invalid-flag.c common.c)
>
>   # vim: ft=cmake:
> diff --git a/tests/egl/spec/egl_khr_create_context/invalid-flag.c b/tests/egl/spec/egl_khr_create_context/invalid-flag.c
> new file mode 100644
> index 0000000..edf939b
> --- /dev/null
> +++ b/tests/egl/spec/egl_khr_create_context/invalid-flag.c
> @@ -0,0 +1,83 @@
> +/* Copyright © 2012 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +#include "piglit-util-gl-common.h"
> +#include "piglit-util-egl.h"
> +#include "common.h"
> +
> +static bool try_flag(uint32_t flag)
> +{
> +	const EGLint attribs[] = {
> +		EGL_CONTEXT_FLAGS_KHR, flag,
> +		EGL_NONE
> +	};
> +	bool pass = true;
> +
> +	ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs);
> +	if (ctx != NULL) {
> +		fprintf(stderr,
> +			"Created OpenGL context with invalid flag 0x%08x, "
> +			"but this should have failed.\n",
> +			flag);
> +		eglDestroyContext(egl_dpy, ctx);
> +		pass = false;
> +	}
> +
> +	/* The EGL_KHR_create_context spec says:
> +	 *
> +	 *     "* If an attribute name or attribute value in <attrib_list> is not
> +	 *        recognized (including unrecognized bits in bitmask attributes),
> +	 *        then an EGL_BAD_ATTRIBUTE error is generated."
> +	 */
> +	piglit_expect_egl_error(EGL_BAD_ATTRIBUTE, PIGLIT_FAIL);
> +
> +	return pass;
> +}
> +
> +
> +int main(int argc, char **argv)
> +{
> +	bool pass = true;
> +	uint32_t flag = 0x80000000;
> +	uint32_t first_valid_flag = EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR;
> +
> +	EGL_KHR_create_context_setup();
> +
> +	/* If EGL_EXT_create_context_robustness is supported, the first flag
> +	 * that can be valid is EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR. Otherwise
> +	 * the first valid flag is EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR.
> +	 */
> +	if (piglit_is_egl_extension_supported(egl_dpy,
> +					      "EGL_EXT_create_context_robustness")) {
> +		first_valid_flag = EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR;
> +	}

This is not correct.  EGL_EXT_create_context_robustness uses a different 
mechanism to create robust contexts for ES2 *only*.  The 
EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR flag is always available for 
desktop OpenGL contexts with EGL_KHR_create_context.

We should also have a test that verifies the EGL_CONTEXT_OPENGL_* values 
are always rejected for ES contexts.

> +
> +	while (flag != first_valid_flag) {
> +		pass = pass && try_flag(flag);
> +		flag >>= 1;
> +	}
> +
> +	EGL_KHR_create_context_teardown();
> +
> +	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +
> +	return EXIT_SUCCESS;
> +}
>