[Piglit] [PATCH] glean: Skip multisample configs

Brian Paul brianp at vmware.com
Thu Aug 9 16:18:08 PDT 2012


On 08/09/2012 05:03 PM, Chad Versace wrote:
> Many tests do not adjust their expectations for mutlisampling and hence
> incorrectly fail.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53275
> Signed-off-by: Chad Versace<chad.versace at linux.intel.com>
> ---
>   tests/glean/tbase.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/glean/tbase.h b/tests/glean/tbase.h
> index f0ec272..b16cc20 100644
> --- a/tests/glean/tbase.h
> +++ b/tests/glean/tbase.h
> @@ -305,6 +305,12 @@ public:
>   				     p = configs.begin();
>   			     p<  configs.end();
>   			     ++p) {
> +				// Many tests do not adjust their expectations
> +				// for mutlisampling and hence incorrectly

"multisampling"

> +				// fail.
> +				if ((*p)->samples>  0)
> +					continue;
> +
>   				Window w(ws, **p, fWidth, fHeight);
>   				RenderingContext rc(ws, **p);
>   				if (!ws.makeCurrent(rc, w)) {

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the Piglit mailing list