[Piglit] [PATCH v2 10/17] egl_khr_create_context: Verify that the invalid flags are rejected for Desktop GL

[Matt Turner]

v2: - Correct value of first_valid_flag.
    - Ask for EGL_OPENGL_API and skip if not available.
---
 tests/all_egl.tests                                |    1 +
 .../spec/egl_khr_create_context/CMakeLists.gl.txt  |    1 +
 .../spec/egl_khr_create_context/invalid-flag-gl.c  |   93 ++++++++++++++++++++
 3 files changed, 95 insertions(+), 0 deletions(-)
 create mode 100644 tests/egl/spec/egl_khr_create_context/invalid-flag-gl.c

diff --git a/tests/all_egl.tests b/tests/all_egl.tests
index f3f4255..305e312 100644
--- a/tests/all_egl.tests
+++ b/tests/all_egl.tests
@@ -26,3 +26,4 @@ create_context['valid attribute empty GLES'] = plain_test('egl-create-context-va
 create_context['NULL valid attribute GLES'] = plain_test('egl-create-context-valid-attribute-null-gles')
 create_context['invalid OpenGL version'] = plain_test('egl-create-context-invalid-gl-version')
 create_context['invalid attribute GL'] = plain_test('egl-create-context-invalid-attribute-gl')
+create_context['invalid flag GL'] = plain_test('egl-create-context-invalid-flag-gl')
diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
index b5aee7c..c93f711 100644
--- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
+++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
@@ -17,5 +17,6 @@ piglit_add_executable (egl-create-context-valid-attribute-empty-gles valid-attri
 piglit_add_executable (egl-create-context-valid-attribute-null-gles valid-attribute-null-gles.c common.c)
 piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
 piglit_add_executable (egl-create-context-invalid-attribute-gl invalid-attribute-gl.c common.c)
+piglit_add_executable (egl-create-context-invalid-flag-gl invalid-flag-gl.c common.c)
 
 # vim: ft=cmake:
diff --git a/tests/egl/spec/egl_khr_create_context/invalid-flag-gl.c b/tests/egl/spec/egl_khr_create_context/invalid-flag-gl.c
new file mode 100644
index 0000000..1aac646
--- /dev/null
+++ b/tests/egl/spec/egl_khr_create_context/invalid-flag-gl.c
@@ -0,0 +1,93 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util-gl-common.h"
+#include "piglit-util-egl.h"
+#include "common.h"
+
+static bool try_flag(uint32_t flag)
+{
+	const EGLint attribs[] = {
+		EGL_CONTEXT_FLAGS_KHR, flag,
+		EGL_NONE
+	};
+	bool pass = true;
+
+	ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs);
+	if (ctx != NULL) {
+		fprintf(stderr,
+			"Created OpenGL context with invalid flag 0x%08x, "
+			"but this should have failed.\n",
+			flag);
+		eglDestroyContext(egl_dpy, ctx);
+		pass = false;
+	}
+
+	/* The EGL_KHR_create_context spec says:
+	 *
+	 *     "* If an attribute name or attribute value in <attrib_list> is not
+	 *        recognized (including unrecognized bits in bitmask attributes),
+	 *        then an EGL_BAD_ATTRIBUTE error is generated."
+	 */
+	piglit_expect_egl_error(EGL_BAD_ATTRIBUTE, PIGLIT_FAIL);
+
+	return pass;
+}
+
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+	uint32_t flag = 0x80000000;
+	uint32_t first_valid_flag = EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR;
+
+	if (EGL_KHR_create_context_setup(EGL_OPENGL_BIT)) {
+		eglBindAPI(EGL_OPENGL_API);
+
+		/* The EGL_KHR_create_context spec says:
+		 *
+		 *	5) What happens when requesting a context requiring OpenGL functionality
+		 *	   that cannot be supported by the underlying GL implementation, such as
+		 *	   requesting lost context reset notification and/or robust buffer access
+		 *	   when the implementation does not support the functionality defined by
+		 *	   GL_ARB_robustness?
+		 *
+		 *	   Context creation will fail and an EGL_BAD_MATCH error will be
+		 *	   generated.
+		 *
+		 * As such, the first valid flag for Desktop GL is always
+		 * EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR.
+		 */
+		first_valid_flag = EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR;
+		while (flag != first_valid_flag) {
+			pass = pass && try_flag(flag);
+			flag >>= 1;
+		}
+
+		EGL_KHR_create_context_teardown();
+	} else {
+		piglit_report_result(PIGLIT_SKIP);
+	}
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+
+	return EXIT_SUCCESS;
+}
-- 
1.7.8.6