[Piglit] [PATCH 15/17] egl_khr_create_context: Verify that the invalid attributes are rejected for GLES

Matt Turner mattst88 at gmail.com
Thu Aug 16 10:51:06 PDT 2012


---
 tests/all_egl.tests                                |    1 +
 .../spec/egl_khr_create_context/CMakeLists.gl.txt  |    1 +
 .../invalid-attribute-gles.c                       |  109 ++++++++++++++++++++
 3 files changed, 111 insertions(+), 0 deletions(-)
 create mode 100644 tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c

diff --git a/tests/all_egl.tests b/tests/all_egl.tests
index ad6f951..afd04d9 100644
--- a/tests/all_egl.tests
+++ b/tests/all_egl.tests
@@ -27,6 +27,7 @@ create_context['valid attribute empty GL'] = plain_test('egl-create-context-vali
 create_context['NULL valid attribute GLES'] = plain_test('egl-create-context-valid-attribute-null-gles')
 create_context['NULL valid attribute GL'] = plain_test('egl-create-context-valid-attribute-null-gl')
 create_context['invalid OpenGL version'] = plain_test('egl-create-context-invalid-gl-version')
+create_context['invalid attribute GLES'] = plain_test('egl-create-context-invalid-attribute-gles')
 create_context['invalid attribute GL'] = plain_test('egl-create-context-invalid-attribute-gl')
 create_context['invalid flag GLES'] = plain_test('egl-create-context-invalid-flag-gles')
 create_context['invalid flag GL'] = plain_test('egl-create-context-invalid-flag-gl')
diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
index 3bae4c1..1b94b1d 100644
--- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
+++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
@@ -18,6 +18,7 @@ piglit_add_executable (egl-create-context-valid-attribute-empty-gl valid-attribu
 piglit_add_executable (egl-create-context-valid-attribute-null-gles valid-attribute-null-gles.c common.c)
 piglit_add_executable (egl-create-context-valid-attribute-null-gl valid-attribute-null-gl.c common.c)
 piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
+piglit_add_executable (egl-create-context-invalid-attribute-gles invalid-attribute-gles.c common.c)
 piglit_add_executable (egl-create-context-invalid-attribute-gl invalid-attribute-gl.c common.c)
 piglit_add_executable (egl-create-context-invalid-flag-gles invalid-flag-gles.c common.c)
 piglit_add_executable (egl-create-context-invalid-flag-gl invalid-flag-gl.c common.c)
diff --git a/tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c b/tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c
new file mode 100644
index 0000000..33ea525
--- /dev/null
+++ b/tests/egl/spec/egl_khr_create_context/invalid-attribute-gles.c
@@ -0,0 +1,109 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util-gl-common.h"
+#include "piglit-util-egl.h"
+#include "common.h"
+
+static bool try_attribute(int attribute)
+{
+	/* If the attribute is EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR
+	 * or EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR, use a valid value for that
+	 * attribute.  This ensures that the attribute is  rejected for the
+	 * correct reason.
+	 */
+	const EGLint attribs[] = {
+		attribute,
+		(attribute == EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR)
+		? EGL_NO_RESET_NOTIFICATION_KHR :
+			(attribute == EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR)
+			? EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR : 0,
+		EGL_NONE
+	};
+	bool pass = true;
+
+	ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs);
+	if (ctx != NULL) {
+		fprintf(stderr,
+			"Created GLES context with invalid attribute "
+			"0x%08x, but this should have failed.\n",
+			attribute);
+		eglDestroyContext(egl_dpy, ctx);
+		pass = false;
+	}
+
+	/* The EGL_KHR_create_context spec says:
+	 *
+	 *     "* If an attribute name or attribute value in <attrib_list> is not
+	 *        recognized (including unrecognized bits in bitmask attributes),
+	 *        then an EGL_BAD_ATTRIBUTE error is generated."
+	 */
+	piglit_expect_egl_error(EGL_BAD_ATTRIBUTE, PIGLIT_FAIL);
+
+	return pass;
+}
+
+int main(int argc, char **argv)
+{
+	/* The EGL_KHR_create_context spec says:
+	 *
+	 *    "The value for attribute EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR
+	 *    specifies a <profile> of the OpenGL API. This attribute is only
+	 *    meaningful for OpenGL contexts, and specifying it for other types of
+	 *    contexts, including OpenGL ES contexts, will generate an error."
+	 *
+	 * and
+	 *
+	 *    "The attribute name
+	 *    EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR specifies the
+	 *    <reset notification behavior> of the rendering context. This
+	 *    attribute is only meaningful for OpenGL contexts, and specifying it
+	 *    for other types of contexts, including OpenGL ES contexts, will
+	 *    generate an error."
+	 */
+	EGLint bad_attributes[] = {
+		0xffff0000,
+		EGL_SAMPLE_BUFFERS,
+		EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR,
+		EGL_CONTEXT_OPENGL_RESET_NOTIFICATION_STRATEGY_KHR
+	};
+	bool pass = true;
+	unsigned i;
+
+	if (!EGL_KHR_create_context_setup(EGL_OPENGL_BIT)) {
+		fprintf(stderr, "ES 1 not available, trying ES 2.\n");
+
+		if (!EGL_KHR_create_context_setup(EGL_OPENGL_ES2_BIT)) {
+			fprintf(stderr, "ES 2 not available.\n");
+			piglit_report_result(PIGLIT_SKIP);
+		}
+	}
+
+	for (i = 0; i < ARRAY_SIZE(bad_attributes); i++) {
+		pass = try_attribute(bad_attributes[i]) && pass;
+	}
+
+	EGL_KHR_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+
+	return EXIT_SUCCESS;
+}
-- 
1.7.8.6



More information about the Piglit mailing list