[Piglit] [PATCH] Allow testing of compressed texture formats with 1D textures

Anuj Phogat anuj.phogat at gmail.com
Thu Aug 16 14:33:42 PDT 2012


OpenGL specification requires generic compressed texture formats to be
supported for 1D, 1D_ARRAY and TEXTURE_RECTANGLE targets.

Brian, after applying this patch I executed test case on NVIDIA drivers. It
fails for all texture formats with 1D textures. But test passes on i965 driver
for cases involving compressed texture formats and 1D textures. Although,
there are few unrelated 1D_ARRAY texture failures i965. I'll verify the output on
AMD as well.

NVIDIA driver I used for testing:
OpenGL renderer string: GeForce 210/PCIe/SSE2
OpenGL version string: 3.3.0 NVIDIA 295.53
OpenGL shading language version string: 3.30 NVIDIA via Cg compiler

Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
---
 tests/texturing/copyteximage.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c
index a0bf228..274618b 100644
--- a/tests/texturing/copyteximage.c
+++ b/tests/texturing/copyteximage.c
@@ -330,10 +330,7 @@ supported_target_format(GLenum target, GLenum format)
 {
 	/* all the compressed formats we test (so far) are 2D only */
 	if (is_compressed_format(format) &&
-	    (target == GL_TEXTURE_1D ||
-	     target == GL_TEXTURE_1D_ARRAY ||
-	     target == GL_TEXTURE_3D ||
-	     target == GL_TEXTURE_RECTANGLE)) {
+	    (target == GL_TEXTURE_3D)) {
 		return false;
 	}
 	if (is_depth_format(format) && target == GL_TEXTURE_3D) {
-- 
1.7.7.6



More information about the Piglit mailing list