[Piglit] [PATCH] copyteximage: Fix the test to eliminate GL_TEXTURE_1D failures on NVIDIA

Matt Turner mattst88 at gmail.com
Tue Aug 21 17:57:08 PDT 2012


On Tue, Aug 21, 2012 at 4:32 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> Draw and probe a QUAD (in place of a LINE) in case of GL_TEXTURE_1D. This
> fixes the test failures on NVIDIA's proprietary linux drivers. In case of
> LINE, glReadPixels() misses the relevant pixels by one pixel on NVIDIA.
>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
> Brian, both these patches (including the one I sent earlier today) resolve
> separate issues. So, I'm keeping this fix in a separate patch. Let me know
> if you have any comments on the patches.
>
>  tests/texturing/copyteximage.c |   16 +++++-----------
>  1 files changed, 5 insertions(+), 11 deletions(-)

I've only been following this casually, but does this cover up a test
failure on NVIDIA? They've got a bug -- right? I don't understand why
we'd want to modify the test so that it misses the driver bug.


More information about the Piglit mailing list