[Piglit] [PATCH] quad-invariance: Fix undefined ReadPixels behavior and make concurrent.

[Kenneth Graunke]

On 08/23/2012 01:17 PM, Eric Anholt wrote:
> ---
>  tests/all.tests                 |    2 +-
>  tests/general/quad-invariance.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/all.tests b/tests/all.tests
> index eb32225..53e0451 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -330,7 +330,7 @@ add_single_param_test_set(
>      )
>  add_plain_test(general, 'provoking-vertex')
>  add_plain_test(general, 'oes-read-format')
> -add_plain_test(general, 'quad-invariance')
> +add_concurrent_test(general, 'quad-invariance')
>  add_plain_test(general, 'read-front')
>  add_concurrent_test(general, 'readpix-z')
>  add_plain_test(general, 'roundmode-getintegerv')
> diff --git a/tests/general/quad-invariance.c b/tests/general/quad-invariance.c
> index 06b818e..64a88e6 100644
> --- a/tests/general/quad-invariance.c
> +++ b/tests/general/quad-invariance.c
> @@ -102,8 +102,6 @@ piglit_display(void)
>  		once = GL_FALSE;
>  	}
>  
> -	glutSwapBuffers();
> -
>  	for (x = 0; x < piglit_width / 2; x++) {
>  		for (y = 0; y < piglit_height; y++) {
>  			float probed[4];
> @@ -116,6 +114,8 @@ piglit_display(void)
>  		}
>  	}
>  
> +	piglit_present_results();
> +
>  	return pass ? PIGLIT_PASS : PIGLIT_WARN;
>  }

Ah, more lovely swap-then-probe code.  Thanks for fixing that.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>