[Piglit] [PATCH 4/5] all.tests: Move GLES1 tests into all.tests

Chad Versace chad.versace at linux.intel.com
Mon Dec 3 10:52:58 PST 2012


On 11/30/2012 03:36 PM, Eric Anholt wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
> 
>> No one runs the GLES1 tests. That needs to be fixed.
>> If you don't build the GLES1 tests, then piglit-run.py will skip them.
> 
>> diff --git a/tests/all.tests b/tests/all.tests
>> index 7881c20..521eec9 100644
>> --- a/tests/all.tests
>> +++ b/tests/all.tests
>> @@ -2635,6 +2635,9 @@ if platform.system() is not 'Windows':
>>  
>>  execfile(path.join(testsDir, 'egl', 'tests.py'))
>>  execfile(path.join(testsDir, 'egl', 'spec', 'egl_khr_create_context', 'tests.py'))
>> +execfile(path.join(testsDir, 'spec', 'oes_compressed_etc1_rgb8_texture', 'tests.py'))
>> +execfile(path.join(testsDir, 'spec', 'oes_compressed_paletted_texture', 'tests.py'))
>> +execfile(path.join(testsDir, 'spec', 'oes_draw_texture', 'tests.py'))
> 
> I'm not a fan.  I think either we should have a canonical name for
> manual test lists that are autodetected like we detect shader_runner
> tests, or just not split them out.
> 
> (I don't feel any particular need to split test lists out, myself)

I don't care so much about splitting the test lists as I do adding the EGL, ES1,
ES2 tests to all.tests. So I'll submit a v2 of the series that only does the
latter.



More information about the Piglit mailing list