[Piglit] [PATCH] framework/shader_test: Assume the api is GL if no requirements are found

Chad Versace chad.versace at linux.intel.com
Tue Dec 11 17:16:02 PST 2012

On 12/11/2012 06:35 PM, Eric Anholt wrote:
> Chad Versace <chad.versace at linux.intel.com> writes:
>> Commit 260f211 caused some shader tests to regress with the message:
>> "Failed to find [require] block".
>> This patch changes the python script that drives shader_runner to assume
>> that the test's API is GL if no GL requirement is found in the test file.
>> This behavior matches the behavior of the shader_runner executable, whose
>> default requirements are GL >= 1.0 and GLSL >= 1.10.
>> I tested this patch by running `piglit-run.py -t glsl -t shader` and then
>> grepping the result file for "Failed to find".
> Changing framework code without doing a whole piglit run? :(

Ok, the sad face sufficiently guilted me.

I just did some full runs, with good results. I'm updating the last paragraph
in the commit message to:

"""I tested this patch with a full Piglit run. The delta against master-ed3903c
consists only of fixes."""

More information about the Piglit mailing list