[Piglit] [PATCH] glean/pointAtten: test fewer combinations, don't call glFinish

[Brian Paul]

On Wed, Dec 12, 2012 at 8:40 AM, Marek Olšák <maraeo at gmail.com> wrote:
> Before:
>   PASS: 87750 antialiased combinations tested.
>   PASS: 87750 aliased combinations tested.
>
>   real   0m16.731s
>   user   0m4.988s
>   sys    0m8.632s
>
> After:
>   PASS: 17550 antialiased combinations tested.
>   PASS: 17550 aliased combinations tested.
>
>   real   0m2.910s
>   user   0m0.880s
>   sys    0m1.544s
> ---
>  tests/glean/tpointatten.cpp |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tests/glean/tpointatten.cpp b/tests/glean/tpointatten.cpp
> index 3fed088..08076ca 100644
> --- a/tests/glean/tpointatten.cpp
> +++ b/tests/glean/tpointatten.cpp
> @@ -38,7 +38,7 @@
>  namespace GLEAN {
>
>  // Max tested point size
> -#define MAX_SIZE 25.0
> +#define MAX_SIZE 24.0
>
>
>  /* Clamp X to [MIN,MAX] */
> @@ -191,11 +191,11 @@ PointAttenuationTest::testPointRendering(GLboolean smooth)
>                         for (int c = -2; c < 3; c++) {
>                                 atten[2] = (c == -1) ? 0.0 : pow(10.0, -c);
>                                 PointParameterfvARB(GL_POINT_DISTANCE_ATTENUATION_ARB, atten);
> -                               for (float min = 1.0; min < MAX_SIZE; min += 5) {
> +                               for (float min = 1.0; min < MAX_SIZE; min += 10) {
>                                         PointParameterfARB(GL_POINT_SIZE_MIN_ARB, min);
> -                                       for (float max = min; max < MAX_SIZE; max += 5) {
> +                                       for (float max = min; max < MAX_SIZE; max += 10) {
>                                                 PointParameterfARB(GL_POINT_SIZE_MAX_ARB, max);
> -                                               for (float size = 1.0; size < MAX_SIZE; size += 4) {
> +                                               for (float size = 1.0; size < MAX_SIZE; size += 8) {
>                                                         glPointSize(size);
>
>                                                         // draw column of points
> @@ -206,8 +206,6 @@ PointAttenuationTest::testPointRendering(GLboolean smooth)
>                                                         }
>                                                         glEnd();
>
> -                                                                       glFinish();
> -
>                                                         // test the column of points
>                                                         for (float z = -6.0; z <= 6.0; z += 1.0) {
>                                                                 count++;


Reviewed-by: Brian Paul <brianp at vmware.com>