[Piglit] [PATCH] Remove #version from variable indexing shader tests.

Chad Versace chad.versace at linux.intel.com
Fri Dec 14 10:26:29 PST 2012

On 12/13/2012 10:00 AM, Stuart Abercrombie wrote:
> The idea is to ultimately remove explicit #version directives from all
> .shader_test files, so we can just rely on GLSL >=, and then the ES
> analog, allowing these tests to run on GL or GLES -- what Paul Berry
> outlined a while back, basically.

I see. If we want to run a shader_test under both GL and GLES, one
of the many steps to arrive there is to generate the #version directive
dynamically. That makes perfect sense.
> This patch is confined to the variable indexing tests.  It removes
> #version outputting from
> tests/spec/glsl-1.10/variable-index-read.sh
> tests/spec/glsl-1.10/variable-index-write.sh
> and the files generated for 1.10/1.20 from these scripts.  I've
> included the script modification below.
> The follow-up was intended to be removal of #version from other
> .shader_test files, and other regularization like what I sent in
> before.
> Since other work is being done for GLES I don't know if this is still
> a reasonable way forward.  Thoughts?

I think this patch is the right way to go forward, it does not conflict
with other GLES changes occurring in Piglit.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

More information about the Piglit mailing list