[Piglit] [PATCH] arb_uniform_buffer: Fix block / field names in dlist test

Eric Anholt eric at anholt.net
Fri Dec 14 12:37:37 PST 2012


Ian Romanick <idr at freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Both the block name and the names of the individual variables in the
> block live at global scope.  Therefore, they can't both have the same
> names.  The GLSL 1.40 spec says:
>
>     "Uniform block names and variable names declared within uniform
>     blocks are scoped at the program level."
>
> Previously this test failed on NVIDIA's closed-source driver (version
> 304.64) with the error messages:
>
> 0(2) : error C1002: the name "a" is already defined at 0(2)
> 0(3) : error C1002: the name "b" is already defined at 0(3)
>
> With this change, the test passes.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121214/725d9cbf/attachment.pgp>


More information about the Piglit mailing list