[Piglit] [PATCH 1/6] glsl: gles2: add version 100

[Eric Anholt]

Chad Versace <chad.versace at linux.intel.com> writes:

> On 12/14/2012 12:01 PM, Tom Gall wrote:
>> This is a small change in two parts to repair support for
>> gles2 by glslparsertest.
>> 
>> To glslparsertest.c, add 100 into the list of versions the switch
>> handles when passed from the command line instead of the default
>> path. Next in piglit_init when version 100 is used, check for
>> gles and if in use don't check for GL_ARB_ES2_compatibility.
>> 
>> Rename the created testcase binary to be gles-2.0-glslparsertest
>> so it's consistant with the gles-3.0 tests. (As well as consistant
>> with the proposed new gles-2.0 tests)
>> 
>> Signed-off-by: Tom Gall <tom.gall at linaro.org>
>> ---
>>  tests/glslparsertest/CMakeLists.gles2.txt |    4 +---
>>  tests/glslparsertest/glslparsertest.c     |    6 +++++-
>>  2 files changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/tests/glslparsertest/CMakeLists.gles2.txt b/tests/glslparsertest/CMakeLists.gles2.txt
>> index 1e37bed..7c24fcc 100644
>> --- a/tests/glslparsertest/CMakeLists.gles2.txt
>> +++ b/tests/glslparsertest/CMakeLists.gles2.txt
>> @@ -3,8 +3,6 @@ link_libraries(
>>  	${OPENGL_gles2_LIBRARY}
>>  	)
>>  
>> -piglit_add_executable(glslparsertest_${piglit_target_api}
>> -	glslparsertest.c
>> -	)
>> +piglit_add_executable(${piglit_target_api}-glslparsertest glslparsertest.c)
>
> Nak the name change. The naming convention used throughout Piglit for libraries,
> executables, and source is to append the basename with the api. For example,
> libpilitutil_gles2. This one executable, glslparsertest, doesn't warrant an
> exception.

Oh, I just commented in another review that I don't like the _apiname
appendage, when for all our tests/spec/ groups we have
groupname-testname.

That said, in the case of a single test file having to be compiled twice
because we don't have piglit-dispatch for gles yet, I'm not sure I care
which way it goes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20121219/c8b69e28/attachment.pgp>