[Piglit] [PATCH 2/2] bindfragdata-link-error: Fix WARN report for a PIGLIT_PASS result.

Eric Anholt eric at anholt.net
Thu Dec 20 16:07:05 PST 2012


By using the complain-loadly-if-link-error util function in the cases
where we expect a link error, we ensured that this test could never
report a pass in the summary.
---
 tests/spec/gl-3.0/api/bindfragdata-link-error.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/spec/gl-3.0/api/bindfragdata-link-error.c b/tests/spec/gl-3.0/api/bindfragdata-link-error.c
index b074bd7..52ee78e 100644
--- a/tests/spec/gl-3.0/api/bindfragdata-link-error.c
+++ b/tests/spec/gl-3.0/api/bindfragdata-link-error.c
@@ -130,7 +130,7 @@ void piglit_init(int argc, char **argv)
 	if (!piglit_check_gl_error(GL_NO_ERROR))
 		piglit_report_result(PIGLIT_FAIL);
 
-	if (piglit_link_check_status(prog)) {
+	if (piglit_link_check_status_quiet(prog)) {
 		fprintf(stderr,
 			"Linking was successful when it should have failed.\n");
 		piglit_report_result(PIGLIT_FAIL);
@@ -161,7 +161,7 @@ void piglit_init(int argc, char **argv)
 	if (!piglit_check_gl_error(GL_NO_ERROR))
 		piglit_report_result(PIGLIT_FAIL);
 
-	if (piglit_link_check_status(prog)) {
+	if (piglit_link_check_status_quiet(prog)) {
 		fprintf(stderr,
 			"Linking was successful when it should have failed.\n");
 		piglit_report_result(PIGLIT_FAIL);
@@ -180,7 +180,7 @@ void piglit_init(int argc, char **argv)
 	if (!piglit_check_gl_error(GL_NO_ERROR))
 		piglit_report_result(PIGLIT_FAIL);
 
-	if (piglit_link_check_status(prog)) {
+	if (piglit_link_check_status_quiet(prog)) {
 		fprintf(stderr,
 			"Linking was successful when it should have failed.\n");
 		piglit_report_result(PIGLIT_FAIL);
-- 
1.7.10.4



More information about the Piglit mailing list