[Piglit] [PATCH] ext_framebuffer_multisample: report SKIP if the FBO is unsupported

Marek Olšák maraeo at gmail.com
Fri Dec 21 12:53:41 PST 2012


Why it reports FAIL in that case is beyond me.

R6xx doesn't support integer formats and R11G11B10 for MSAA rendering.
---
 tests/spec/ext_framebuffer_multisample/common.cpp |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp b/tests/spec/ext_framebuffer_multisample/common.cpp
index 02a8382..fe6b40b 100644
--- a/tests/spec/ext_framebuffer_multisample/common.cpp
+++ b/tests/spec/ext_framebuffer_multisample/common.cpp
@@ -162,17 +162,7 @@ Fbo::setup(const FboConfig &new_config)
 {
 	if (!try_setup(new_config)) {
 		printf("Framebuffer not complete\n");
-		if (!config.combine_depth_stencil) {
-			/* Some implementations do not support
-			 * separate depth and stencil attachments, so
-			 * don't consider it an error if we fail to
-			 * make a complete framebuffer using separate
-			 * depth and stencil attachments.
-			 */
-			piglit_report_result(PIGLIT_SKIP);
-		} else {
-			piglit_report_result(PIGLIT_FAIL);
-		}
+		piglit_report_result(PIGLIT_SKIP);
 	}
 }
 
-- 
1.7.10.4



More information about the Piglit mailing list