[Piglit] [PATCH] apple_vertex_array_object: Initialize variable apple.

Matt Turner mattst88 at gmail.com
Mon Dec 31 15:50:16 PST 2012


On Sat, Dec 22, 2012 at 1:07 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fixes uninitialized scalar variable defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  tests/spec/arb_vertex_array_object/isvertexarray.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/arb_vertex_array_object/isvertexarray.c b/tests/spec/arb_vertex_array_object/isvertexarray.c
> index 35e8862..9976ca0 100644
> --- a/tests/spec/arb_vertex_array_object/isvertexarray.c
> +++ b/tests/spec/arb_vertex_array_object/isvertexarray.c
> @@ -73,6 +73,8 @@ piglit_init(int argc, char **argv)
>         if (argc == 2 && strcmp(argv[1], "apple") == 0) {
>                 printf("apple\n");
>                 apple = GL_TRUE;
> +       } else {
> +               apple = GL_FALSE;
>         }
>
>         piglit_require_gl_version(15);
> --
> 1.8.0.1

Just initialize it when the variable is declared. I'd give that a
Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list