[Piglit] [PATCH] framework: Don't override result to 'fail' on returncode != 0.

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/27/2012 02:08 PM, Kenneth Graunke wrote:
> We do want to override interpretResult() for crashes, but not for generic
> failures.  So default to 'fail', call interpretResult(), then check for
> crashes.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  framework/exectest.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Found this patch lying around in one of my branches.  My guess is that
> oglconform returns a non-zero exit code even on pass, while other tests
> don't.  Regardless, it seems harmless enough, so I figured I'd send it on.

Yes, I've seen oglconform return 130 on a pass. This patch looks safe to me.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPKYcZAAoJEAIvNt057x8iJ7gP/1ouMx/pFALQx6g806cu5Tu9
IJwmReE2Vp5a6ygtcmJQM0d8P7w1NJRQKMKEu+mr01fE+wIvQhVZaBdZsJk1Vqf3
mTROdss7h5RvWtmHy0YSgIwu7JAxkiHdQZrytctVwG1dM5vgOkzNI1x7Kw2XelqV
+CGkUMuOHLq3mzwg/5mFbuHY/fRxnBcThpBoQG53vTZQdkWzOE3LADiJrFquBQrm
ysd5UuO+x6kBrorGbWYgw1J+uCMxVEnZaZHpsWXcXcF5t067dG6LdIgA7Dhaqf5/
fb2aapICAG+GmAISzOsvlreAt3sRSsjerB5Ns98vCW0kBjisDl+ymryRB7azxFZK
teMU6rNBaODii4c/31BQK7b9uOjPY6ZaiL8DBzvvuJizxTDEQFkJUJndcIXJWQbS
K6I8wiUqhVayiUfoGRFJBIXkkMGNhwpcnwUHeCn/TQlqGR3gkzfQpQkwlYiTgx/0
54wcDsqsq8MNqCBy4twr4QLcErBwQa8mCKxMvwiffM6crMOM4H4WDwEPAf5mRIEv
ai2pVLSCqzZ5RrUNvv4lW55SBuQXbXxFtSIwZp/1R/Tf8StdRB8R9MxwVFVtTDBg
AqleDIKvIOrf5KaIwPPcDusPxxONTeKZGCjxNiMlUAjd0LH2yDEAeUJ0nyC4UNqv
vsm8VwmojDNgQIGcbRI+
=LDbG
-----END PGP SIGNATURE-----