[Piglit] [PATCH 09/11] all.tests: Add all the asmparsertest programs implicitly.

Jose Fonseca jfonseca at vmware.com
Thu Feb 2 05:27:43 PST 2012


----- Original Message -----
> If you drop a file into asmparsertests/shaders, it's probably a new
> ARB program you'd like tested.  Eliminates the fuss of adding them to
> all.tests, along with a lot of lines of pointless code.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  tests/all.tests |  449
>  +-----------------------------------------------------
>  1 files changed, 9 insertions(+), 440 deletions(-)
> 
> diff --git a/tests/all.tests b/tests/all.tests
> index b48ef9a..5843080 100644
> --- a/tests/all.tests
> +++ b/tests/all.tests
> @@ -4,6 +4,8 @@
>  import os
>  import os.path as path
>  
> +from glob import glob
> +
>  from framework.core import *
>  from framework.exectest import *
>  from framework.gleantest import *
> @@ -1609,445 +1611,13 @@ add_plain_test(hiz,
[...]
> +# Add all the asmparsertests
> +for lang in ('ARBvp1.0', 'ARBfp1.0'):
> +	for shader in glob(path.join('tests', 'asmparsertest', 'shaders',

Please use the testsDir variable instead of 'tests', to avoid breaking when PWD != top dir. 

Otherwise looks good. I think this is a nice cleanup.

Jose


More information about the Piglit mailing list