[Piglit] [PATCH 2/2] Remove unnecessary glewInit calls

Chad Versace chad.versace at linux.intel.com
Fri Feb 24 11:48:10 PST 2012


On 02/22/2012 01:29 PM, Paul Berry wrote:
> This patch removes extraneous glewInit() calls from piglit_init()
> functions.  These calls are unnecessary since the Piglit framework
> calls glewInit() before calling piglit_init().
> ---
>  tests/general/draw-elements-base-vertex-bounds.c |    1 -
>  tests/general/draw-elements-vs-inputs.c          |    2 --
>  tests/general/gl30basic.c                        |    1 -
>  tests/general/isbufferobj.c                      |    2 --
>  tests/general/pbo-drawpixels.c                   |    1 -
>  tests/general/pbo-teximage-tiling-2.c            |    1 -
>  tests/general/pbo-teximage-tiling.c              |    1 -
>  tests/general/pbo-teximage.c                     |    1 -
>  tests/shaders/fp-fog.c                           |    1 -
>  9 files changed, 0 insertions(+), 11 deletions(-)

After the previous patch, only three groups of tests still define main():
   tests/egl/*.c
   tests/glean/main.cpp
   tests/glx/*.c
Since all the others now use piglit_init(), this patch looks safe to me.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the Piglit mailing list