[Piglit] [PATCH] Add test case to verify large textures are handled correctly in mesa

[Brian Paul]

On 02/23/2012 08:27 PM, Anuj Phogat wrote:
> Intel driver throws GL_OUT_OF_MEMORY and assertion failure / segmentation
> fault with large textures.
>
> Reproduces the errors reported in:
> https://bugs.freedesktop.org/show_bug.cgi?id=44970
> https://bugs.freedesktop.org/show_bug.cgi?id=46303
>
> Signed-off-by: Anuj Phogat<anuj.phogat at gmail.com>
> ---
> V3: Added the test using proxy textures, deleted redundant code,
>      data array allocation based on size returned
>
> ToDo: getMaxTarget, getProxyTarget and isValidTexSize functions can be added
>        as piglit utility functions in piglit-util-gl.c
>        I will do it in a separate patch.
>
>   tests/all.tests              |    1 +
>   tests/bugs/CMakeLists.gl.txt |    1 +
>   tests/bugs/large-textures.c  |  352 ++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 354 insertions(+), 0 deletions(-)
>   create mode 100644 tests/bugs/large-textures.c


> diff --git a/tests/bugs/large-textures.c b/tests/bugs/large-textures.c
> new file mode 100644
> index 0000000..c43f51e
> --- /dev/null
> +++ b/tests/bugs/large-textures.c
> @@ -0,0 +1,352 @@

The test should be moved to test/texturing/.  I think we agreed to 
move away from the tests/bugs/ directory.



[...]

> +void piglit_init(int argc, char **argv)
> +{
> +	GLuint tex;
> +	int i, j;
> +
> +	glMatrixMode(GL_PROJECTION);
> +	glPushMatrix();
> +	glLoadIdentity();
> +	glOrtho(0, piglit_width, 0, piglit_height, -1, 1);
> +	glMatrixMode(GL_MODELVIEW);
> +	glPushMatrix();
> +	glLoadIdentity();
> +	glClearColor(0.2, 0.2, 0.2, 1.0);
> +	glClear(GL_COLOR_BUFFER_BIT);
> +
> +	for ( i = 0; i<  ARRAY_SIZE(target); i++) {
> +
> +		glGenTextures(1,&tex);
> +		glBindTexture(target[i], tex);
> +		glTexParameteri(target[i], GL_TEXTURE_MIN_FILTER, GL_NEAREST);
> +		glTexParameteri(target[i], GL_TEXTURE_MAG_FILTER, GL_NEAREST);
> +
> +		for (j = 0; j<  ARRAY_SIZE(internalformat); j++) {
> +
> +			if (internalformat[j] == GL_RGBA16F ||
> +			    internalformat[j] == GL_RGBA32F)
> +				piglit_require_extension("GL_ARB_texture_float");

I think you should simply skip the float formats if 
GL_ARB_texture_float is not supported (don't exit with SKIP result).


I ran the test with NVIDIA's driver.  Here's what it printed:

GL_PROXY_TEXTURE_1D, Internal Format = GL_RGBA8, Largest Texture Size 
= 16384
GL_PROXY_TEXTURE_1D, Internal Format = GL_RGBA16, Largest Texture Size 
= 16384
GL_PROXY_TEXTURE_1D, Internal Format = GL_RGBA32F, Largest Texture 
Size = 16384
GL_PROXY_TEXTURE_2D, Internal Format = GL_RGBA8, Largest Texture Size 
= 16384
GL_PROXY_TEXTURE_2D, Internal Format = GL_RGBA16, Largest Texture Size 
= 16384
GL_PROXY_TEXTURE_2D, Internal Format = GL_RGBA32F, Largest Texture 
Size = 16384
GL_PROXY_TEXTURE_CUBE_MAP, Internal Format = GL_RGBA8, Largest Texture 
Size = 16384
GL_PROXY_TEXTURE_CUBE_MAP, Internal Format = GL_RGBA16, Largest 
Texture Size = 16384
GL_PROXY_TEXTURE_CUBE_MAP, Internal Format = GL_RGBA32F, Largest 
Texture Size = 16384
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA8, Largest Texture Size 
= 2048
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA16, Largest Texture Size 
= 2048
GL_PROXY_TEXTURE_3D, Internal Format = GL_RGBA32F, Largest Texture 
Size = 2048

GL_TEXTURE_1D, Internal Format = GL_RGBA8, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_1D, Internal Format = GL_RGBA16, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_1D, Internal Format = GL_RGBA32F, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_2D, Internal Format = GL_RGBA8, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_2D, Internal Format = GL_RGBA16, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_2D, Internal Format = GL_RGBA32F, Largest Texture Size = 16384
Unexpected GL error: GL_INVALID_VALUE 0x501
Unexpected GL error: GL_INVALID_VALUE 0x501
Unexpected GL error: GL_INVALID_VALUE 0x501
Unexpected GL error: GL_INVALID_VALUE 0x501
Unexpected GL error: GL_INVALID_VALUE 0x501
Unexpected GL error: GL_INVALID_VALUE 0x501
GL_TEXTURE_CUBE_MAP, Internal Format = GL_RGBA16, Largest Texture Size 
= 16384
[I killed it here after 10+ minutes of runtime]



I don't know what's causing the INVALID_VALUE error.  The test runs 
_extremely_ slowly.  It looks like the driver is allocating some 
really large image buffers so we're falling back to virtual memory.  I 
don't know a way around this.  On one hand, it's good to test this, 
but nobody wants to wait 10+ minutes for the outcome.

-Brian