[Piglit] [PATCH] Add test case to verify large textures are handled correctly in mesa

Eric Anholt eric at anholt.net
Tue Feb 28 13:51:15 PST 2012

On Tue, 28 Feb 2012 12:26:03 -0800, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> This test tries to create the maximum supported texture using
> gltexImage1D/2D/3D functions and later modifies it using
> glTexSubImage1D/2D/3D functions.
> At the moment Intel driver throws GL_OUT_OF_MEMORY and an assertion
> failure / a segmentation fault with large textures.
> Test reproduces the errors reported in:
> https://bugs.freedesktop.org/show_bug.cgi?id=44970
> https://bugs.freedesktop.org/show_bug.cgi?id=46303
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
> V3: Added the test using proxy textures, deleted redundant code,
>     data array allocation based on size returned
> V4: Continue testing with other formats if ARB_texture_float is not present.
>     Moved the test case to tests/texturing with an appropriate name.
>     Removed the loop which was testing with a number of large textures.
>     Added GL_OUT_OF_MEMORY as an expected error.
>     Added GL_TEXTURE_RECTANGLE in texture target array.
> ToDo: getMaxTarget, getProxyTarget and isValidTexSize functions can be added
>       as piglit utility functions in piglit-util-gl.c
>       I will do it in a separate patch.

Please include the v2/v3/v4 information in the commit message, rather
than inserting it below the --- after doing git format-patch.  The
advantage to doing so is that if someone else applies your patch, it's
recorded which version of yours they applied, and even if not, others
get to see what went into building the version of the code that landed
while doing git log.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120228/560d16df/attachment.pgp>

More information about the Piglit mailing list