[Piglit] [PATCH 5/5] EXT_framebuffer_multisample/negative-readpixels: New test for mesa bug.

Eric Anholt eric at anholt.net
Tue Jan 10 16:49:15 PST 2012


On Mon, 09 Jan 2012 14:42:52 -0800, Ian Romanick <idr at freedesktop.org> wrote:
> On 01/05/2012 07:53 PM, Eric Anholt wrote:
> > diff --git a/tests/spec/ext_framebuffer_multisample/negative-readpixels.c b/tests/spec/ext_framebuffer_multisample/negative-readpixels.c

> > +void
> > +piglit_init(int argc, char **argv)
> > +{
> > +	GLint max_samples, sample_buffers;
> > +	GLuint rb, fb;
> > +	GLenum status;
> > +	bool pass = true;
> > +	float data[4];
> > +
> > +	piglit_require_extension("GL_EXT_framebuffer_multisample");
> > +
> > +	glGetIntegerv(GL_MAX_SAMPLES,&max_samples);
> > +	piglit_check_gl_error(0, PIGLIT_FAIL);
> 
> 	if (max_samples == 0)
> 		piglit_report_result(PIGLIT_SKIP);
> 
> Right?  Otherwise the test for sample_buffers != 1 (below) will fail.

The minmax is 1, so 0 would be fail.  I should check that...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120110/44d34824/attachment.pgp>


More information about the Piglit mailing list