[Piglit] [PATCH 4/7] ARB_copy_buffer/negative-bounds: New test for spec behavior.

Eric Anholt eric at anholt.net
Wed Jan 25 17:36:12 PST 2012


---
 tests/all.tests                              |    1 +
 tests/spec/arb_copy_buffer/CMakeLists.gl.txt |    1 +
 tests/spec/arb_copy_buffer/negative-bounds.c |   88 ++++++++++++++++++++++++++
 3 files changed, 90 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/arb_copy_buffer/negative-bounds.c

diff --git a/tests/all.tests b/tests/all.tests
index 577bf8c..1288912 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1608,6 +1608,7 @@ spec['ARB_copy_buffer'] = arb_copy_buffer
 add_plain_test(arb_copy_buffer, 'copy_buffer_coherency')
 add_plain_test(arb_copy_buffer, 'copybuffersubdata')
 arb_copy_buffer['negative-bound-zero'] = concurrent_test('arb_copy_buffer-negative-bound-zero')
+arb_copy_buffer['negative-bounds'] = concurrent_test('arb_copy_buffer-negative-bounds')
 arb_copy_buffer['negative-mapped'] = concurrent_test('arb_copy_buffer-negative-mapped')
 arb_copy_buffer['overlap'] = concurrent_test('arb_copy_buffer-overlap')
 
diff --git a/tests/spec/arb_copy_buffer/CMakeLists.gl.txt b/tests/spec/arb_copy_buffer/CMakeLists.gl.txt
index 0aef94a..9b683db 100644
--- a/tests/spec/arb_copy_buffer/CMakeLists.gl.txt
+++ b/tests/spec/arb_copy_buffer/CMakeLists.gl.txt
@@ -15,6 +15,7 @@ add_executable (copy_buffer_coherency copy_buffer_coherency.c)
 add_executable (copybuffersubdata copybuffersubdata.c)
 add_executable (arb_copy_buffer-overlap overlap.c)
 add_executable (arb_copy_buffer-negative-bound-zero negative-bound-zero.c)
+add_executable (arb_copy_buffer-negative-bounds negative-bounds.c)
 add_executable (arb_copy_buffer-negative-mapped negative-mapped.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_copy_buffer/negative-bounds.c b/tests/spec/arb_copy_buffer/negative-bounds.c
new file mode 100644
index 0000000..aa0a6ab
--- /dev/null
+++ b/tests/spec/arb_copy_buffer/negative-bounds.c
@@ -0,0 +1,88 @@
+/*
+ * Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/** @file negative-bounds.c
+ *
+ * Tests the following piece of the GL_ARB_copy_buffer spec:
+ *
+ *     "An INVALID_VALUE error is generated if any of readoffset,
+ *      writeoffset, or size are negative, if readoffset+size exceeds
+ *      the size of the buffer object bound to readtarget, or if
+ *      writeoffset+size exceeds the size of the buffer object bound
+ *      to writetarget."
+ *
+ * Note that the overlap test, as an example, will make sure that the
+ * error checking doesn't fail copies within the bounds.
+ */
+
+#include "piglit-util.h"
+
+int piglit_width = 100, piglit_height = 100;
+int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE;
+
+enum piglit_result
+piglit_display(void)
+{
+	/* uncreached */
+	return PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	GLuint bufs[2];
+	uint8_t data[8] = { 0 };
+
+	piglit_require_extension("GL_ARB_copy_buffer");
+
+	glGenBuffers(2, bufs);
+
+	glBindBuffer(GL_COPY_READ_BUFFER, bufs[0]);
+	glBufferData(GL_COPY_READ_BUFFER, sizeof(data), data, GL_DYNAMIC_DRAW);
+	glBindBuffer(GL_COPY_WRITE_BUFFER, bufs[1]);
+	glBufferData(GL_COPY_WRITE_BUFFER, sizeof(data), data, GL_DYNAMIC_DRAW);
+
+	glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER,
+			    -1, 0, 1);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		piglit_report_result(PIGLIT_FAIL);
+
+	glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER,
+			    0, -1, 1);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		piglit_report_result(PIGLIT_FAIL);
+
+	glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER,
+			    sizeof(data) - 1, 0, 2);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		piglit_report_result(PIGLIT_FAIL);
+
+	glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER,
+			    0, sizeof(data) - 1, 2);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		piglit_report_result(PIGLIT_FAIL);
+
+	glDeleteBuffers(2, bufs);
+
+	piglit_report_result(PIGLIT_PASS);
+}
-- 
1.7.7.3



More information about the Piglit mailing list