[Piglit] [PATCH 0/5] Consolidate CLAMP, MIN2, MAX2, and ARRAY_SIZE macros.

Chad Versace chad.versace at linux.intel.com
Thu Jan 26 09:50:38 PST 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/25/2012 05:56 PM, Paul Berry wrote:
> Many .c files in Piglit define some subset of the macros CLAMP, MIN2,
> MAX2, and ELEMENTS/ARRAY_SIZE, occasionally with variations in name
> and/or calling convention.  This patch standardizes all of the macros
> and consolidates the definitions into one place, piglit-util.h.
> 
> Exception: I didn't touch the macros in Glean, since Glean is
> independent of piglit-util.
> 
> No change in Piglit results on Sandy Bridge.
> 
> [PATCH 1/5] Standardize argument order for CLAMP.
> [PATCH 2/5] Rename MAX to MAX2 in texunits.c.
> [PATCH 3/5] Make readtex.c include piglit-util.h.
> [PATCH 4/5] Move CLAMP, MIN2, and MAX2 macros to piglit-util.h.
> [PATCH 5/5] Change ELEMENTS macros to ARRAY_SIZE.

Thanks for killing the ELEMENTS macro.

For the series,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPIZJsAAoJEAIvNt057x8i8cMP/j5gdd/dk1ckHzj0nCkGbAlb
TSIuG2pnn7Wdk4l1PQADFugvQPWy74389AZmtmt0tNyNElCrRm26oFN0YVGe3sO9
387f6fNZM1/vAjKOO/P+NtHvUJ+mSgZpRBbIsGoUGUhZgpSZ4p12awhtnUfsheue
MKDl2L0zfa16oJuxUuVp9A488rDZuyUGLi8DJFT2dnBJrl1LfXBxXIUkK+2/x3Iz
ETFA+KRhjfHRtOZKPfqqbAklX8bnGIbM/ZzAo0iBjX6Hn+SO6dm3UVCXFdSSg5PZ
u1hi+zd7XMwTOz3RFtrXhMpT0hE1YqAzAuH5XU6FFltfvvYZmIrbRAbs4xakyoHG
FXxozq3zBeBDwejWpmL4Yr+7s0D5F9SypL9h2BVxU0354PTVIlI7v/PZUS3+9tdX
qbPZfAHzYuyUZS2BMQgSuXt4q0yelNhqc53uZ8yEdiHq9IQE43Odyf6J8HHJyu1I
Y3GZFwF9BI9YcHIawU9bBfi50dnaNA0sbARYxDAFO2xP4CqR6AMukjNdEOfOhJcm
ryX/vmDQQDb8PWIkvycZD/BGzvuctaweCBfCWq9x42S89euCZGh7Ze30Xkq3Tkrt
HaN8v1IytRT0ZWE0GSUWX5NVCVO9k/RQFer+RpQL4HKRkDb/f5T4I0ZxuHdt1KyQ
2qpw5YJ47F1XLpeyOmL1
=YfY+
-----END PGP SIGNATURE-----


More information about the Piglit mailing list