[Piglit] [PATCH] Make piglitutil library API-independent

Eric Anholt eric at anholt.net
Mon Jul 2 08:54:38 PDT 2012

Chad Versace <chad.versace at linux.intel.com> writes:

> Hash: SHA1
> On 06/26/2012 05:56 AM, Blaž Tomažič wrote:
>> On pet, 2012-06-22 at 15:12 -0700, Chad Versace wrote:
>> I have received an email from Eric Anholt about the patches (don't
>> know why he didn't cc the mailing list, he probably forgot)
> He has been doing that to everyone recently. I suspect he accidentally
> broke his email client's config.
>> and he raises a question why do the new files have '-common' in their
>> names (piglit-util-gl-common.[ch]). I named them this way because
>> they have code common to gl and gles. But while we can't have code
>> from piglit-util-gl-common.c in piglit-util-gl.c (because then the
>> contents should be copied to piglit-util-gles.c too), we can have the
>> gl/gles utilities header in piglit-util-gl.h instead of
>> piglit-util-gl-common.h. So which name should we use for the header?
> I think piglit-util-gl-common.c is a reasonable name for that file. I
> can think of no better. It's name clearly indicates what it defines:
> utility functions common to all GL API's.
> As for piglit-util-gl-common.h, I'm uncertain if that is the best
> name, but I can think of no better.
> I think piglit-util-gl.h is a bad choice. It obfuscates the naming
> convention that you establish in this series: files named *-gl.[ch]
> provide utilities for GL (not GLES), and files named *-gles.[ch]
> provide utilities for GLES (not GL).  To name a common header *-gl.h
> may be more convenient for the test writer (it saves 7 characters),
> but is inconsitent with that convention. I prefer consistency to
> convenience here, and would rather not introduce the inevitable
> confusion that would result from naming the file piglit-util-gl.h.

You've convinced me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120702/790cd25a/attachment.pgp>

More information about the Piglit mailing list