[Piglit] [PATCH 4/7] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

Chad Versace chad.versace at linux.intel.com
Mon Jul 9 09:22:28 PDT 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> The overall test looks good, but...
>> 
>>> +        (*func)(GL_VERTEX_SHADER, GL_MEDIUM_FLOAT, r, &p); +        if
>>> (r[0] < 14 || r[1] < 14 || p < 16) {
>> ^^^^^^ The GLSL ES 1.0 spec states that the minimum required value of p
>> for mediump is 10, not 16. 16 is the minimum required for highp.
> 
> You are completely correct.  I was trying to borrow from the 
> arb_es2_compatibility-getshaderprecisionformat test, and I just did it
> wrong.
> 
>> - -Chad
> 

Ok, other than that, this is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP+wVDAAoJEAIvNt057x8ikMUP/RKmiRRVfMuhimX/UKMWQVTx
MAGDo5sOlWG9r1SQutI45dOEYyQDlg6TmU0OogKG2Xed3u0cG43FNiKF0Q9GnzrP
b6HuUJGwBdgMYolNClAOpmDRLBNmX2cKxNIuqTbdhp1jyHwvfPmqc6iMON1GP2QG
0FtVgclf8lkKXt7NTzDzDWM+lnZiiu1HTEgTTQ04VR/3UXLB4qgP1vqugaBjn0iF
dKdaE31+eMpqf0uE+Y3t6RjoJKuBltXRjKz4RLKUJq52GlKGFZb1+LJRn1RUWEeq
CAXZz1jduOgj0D7qo+kmC75i+XCcF2+dCanfVyJXPEYNrm2QZanT3jn2kf7B2F+u
3lvcfgwwsFadn53py8T4sia3ZbGlZ213OD+1FiiC/SBgMaOyXcR/BBvkBgABIp9y
255jTVXeI40NIQABihwYKyM5qPLzB8JmiHVJ6mOEfzRi0IcohksjXYU9sTRgS8T+
n1PL1BFXYltP7NMp+DcFZmARlsc/1+/1b2wxPViWtubtV1izCPx5AU03s/FRtAdM
7oNC34JW9KtQJTcnqPB8OZ8GXMipPz/uhb1pQKseqyUW+ABHTvYRzV1MVVn85kbn
xhe0QeY8srmSdjdA+cak1/1/9bOQxx373Az21GT/AOge2b7wI+/W+zFH72m3K5P/
n5fY0XRYJ95suqw38eOM
=mpq/
-----END PGP SIGNATURE-----


More information about the Piglit mailing list