[Piglit] [PATCH 1/5] arb_transform_feedback2: Require that xfb object names come from Gen

[Ian Romanick]

From: Ian Romanick <ian.d.romanick at intel.com>

NVIDIA's closed-source driver passes this test.  AMD's closed-source
driver has not been tested.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |    1 +
 .../spec/arb_transform_feedback2/CMakeLists.gl.txt |    1 +
 .../spec/arb_transform_feedback2/gen-names-only.c  |   72 ++++++++++++++++++++
 3 files changed, 74 insertions(+), 0 deletions(-)
 create mode 100644 tests/spec/arb_transform_feedback2/gen-names-only.c

diff --git a/tests/all.tests b/tests/all.tests
index 892dffd..cc4218f 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1862,6 +1862,7 @@ for mode in ['discard', 'buffer', 'prims_generated', 'prims_written']:
 arb_transform_feedback2 = Group()
 spec['ARB_transform_feedback2'] = arb_transform_feedback2
 arb_transform_feedback2['draw-auto'] = PlainExecTest(['arb_transform_feedback2-draw-auto', '-auto'])
+arb_transform_feedback2['glGenTransformFeedbacks names only'] = concurrent_test('arb_transform_feedback2-gen-names-only')
 
 arb_transform_feedback_instanced = Group()
 spec['ARB_transform_feedback_instanced'] = arb_transform_feedback_instanced
diff --git a/tests/spec/arb_transform_feedback2/CMakeLists.gl.txt b/tests/spec/arb_transform_feedback2/CMakeLists.gl.txt
index 9e76e7a..ff10a9c 100644
--- a/tests/spec/arb_transform_feedback2/CMakeLists.gl.txt
+++ b/tests/spec/arb_transform_feedback2/CMakeLists.gl.txt
@@ -10,5 +10,6 @@ link_libraries (
 )
 
 piglit_add_executable (arb_transform_feedback2-draw-auto draw-auto.c)
+piglit_add_executable (arb_transform_feedback2-gen-names-only gen-names-only.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_transform_feedback2/gen-names-only.c b/tests/spec/arb_transform_feedback2/gen-names-only.c
new file mode 100644
index 0000000..5c3f07f
--- /dev/null
+++ b/tests/spec/arb_transform_feedback2/gen-names-only.c
@@ -0,0 +1,72 @@
+/*
+ * Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file gen-names-only.c
+ *
+ * The ARB_transform_feedback2 spec says:
+ *
+ *     "BindTransformFeedback fails and an INVALID_OPERATION error is
+ *     generated if <id> is not zero or a name returned from a previous
+ *     call to GenTransformFeedbacks, or if such a name has since been
+ *     deleted with DeleteTransformFeedbacks."
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_MAIN(
+    10 /*window_width*/,
+    10 /*window_height*/,
+    GLUT_RGB)
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+void piglit_init(int argc, char **argv)
+{
+	GLuint id;
+	bool pass = true;
+
+	piglit_require_transform_feedback();
+	piglit_require_extension("GL_ARB_transform_feedback2");
+
+	glGenTransformFeedbacks(1, &id);
+
+	glBindTransformFeedback(GL_TRANSFORM_FEEDBACK, 0);
+	pass = piglit_check_gl_error(0) && pass;
+
+	glBindTransformFeedback(GL_TRANSFORM_FEEDBACK, 47);
+	pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
+
+	glBindTransformFeedback(GL_TRANSFORM_FEEDBACK, id);
+	pass = piglit_check_gl_error(0) && pass;
+
+	glDeleteTransformFeedbacks(1, &id);
+	glBindTransformFeedback(GL_TRANSFORM_FEEDBACK, id);
+	pass = piglit_check_gl_error(GL_INVALID_OPERATION) && pass;
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
1.7.6.5