[Piglit] [PATCH] Test that fragment shader writes to render targets are properly ordered.

Eric Anholt eric at anholt.net
Mon Jul 30 10:40:28 PDT 2012


Paul Berry <stereotype441 at gmail.com> writes:
> +	"  for (uint i = 2u; i < number_to_classify; ++i) {\n"
> +	"    if (number_to_classify % i == 0u)\n"
> +	"      factor_found = true;\n"
> +	"  }\n"

not breaking out of the loop if you find a factor :)

> +enum piglit_result
> +piglit_display(void)
> +{
> +	enum piglit_result result = PIGLIT_PASS;
> +	unsigned size;

needs

	piglit_require_glsl_version(130);

I think.

> +
> +	glUseProgram(prog);
> +	glClear(GL_COLOR_BUFFER_BIT);

Other than the require_version,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20120730/920ae453/attachment.pgp>


More information about the Piglit mailing list