[Piglit] [PATCH 08/11] egl_khr_create_context: Verify that the invalid GL versions are rejected

Matt Turner mattst88 at gmail.com
Tue Jul 31 18:38:39 PDT 2012


---
 tests/all_egl.tests                                |    1 +
 .../spec/egl_khr_create_context/CMakeLists.gl.txt  |    1 +
 .../egl_khr_create_context/invalid-gl-version.c    |  110 ++++++++++++++++++++
 3 files changed, 112 insertions(+), 0 deletions(-)
 create mode 100644 tests/egl/spec/egl_khr_create_context/invalid-gl-version.c

diff --git a/tests/all_egl.tests b/tests/all_egl.tests
index f1c6fd8..97b378f 100644
--- a/tests/all_egl.tests
+++ b/tests/all_egl.tests
@@ -24,3 +24,4 @@ create_context['default major version'] = plain_test(['egl-create-context-defaul
 create_context['default minor version'] = plain_test(['egl-create-context-default-minor-version'])
 create_context['valid attribute empty'] = plain_test(['egl-create-context-valid-attribute-empty'])
 create_context['NULL valid attribute'] = plain_test(['egl-create-context-valid-attribute-null'])
+create_context['invalid OpenGL version'] = plain_test(['egl-create-context-invalid-gl-version'])
diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
index 7d80e84..e8793a8 100644
--- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
+++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
@@ -15,5 +15,6 @@ piglit_add_executable (egl-create-context-default-major-version default-major-ve
 piglit_add_executable (egl-create-context-default-minor-version default-minor-version.c common.c)
 piglit_add_executable (egl-create-context-valid-attribute-empty valid-attribute-empty.c common.c)
 piglit_add_executable (egl-create-context-valid-attribute-null valid-attribute-null.c common.c)
+piglit_add_executable (egl-create-context-invalid-gl-version invalid-gl-version.c common.c)
 
 # vim: ft=cmake:
diff --git a/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
new file mode 100644
index 0000000..bd23028
--- /dev/null
+++ b/tests/egl/spec/egl_khr_create_context/invalid-gl-version.c
@@ -0,0 +1,110 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+#include "piglit-util-gl-common.h"
+#include "piglit-util-egl.h"
+#include "common.h"
+
+static bool try_version(int major, int minor)
+{
+	const EGLint attribs[] = {
+		EGL_CONTEXT_MAJOR_VERSION_KHR, major,
+		EGL_CONTEXT_MINOR_VERSION_KHR, minor,
+		EGL_NONE
+	};
+	bool pass = true;
+
+	ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs);
+	if (ctx != NULL) {
+		fprintf(stderr,
+			"Created OpenGL context with invalid version %d.%d\n",
+			major, minor);
+		eglDestroyContext(egl_dpy, ctx);
+		pass = false;
+	}
+
+	/* The EGL_KHR_create_context spec says:
+	 *
+	 *     "If an OpenGL context is requested and the values for attributes
+	 *     EGL_CONTEXT_MAJOR_VERSION_KHR and EGL_CONTEXT_MINOR_VERSION_KHR,
+	 *     when considered together with the value for attribute
+	 *     EGL_CONTEXT_FORWARD_COMPATIBLE_BIT_KHR, specify an OpenGL
+	 *     version and feature set that are not defined, than an
+	 *     EGL_BAD_MATCH error is generated."
+	 */
+	piglit_expect_egl_error(EGL_BAD_MATCH, PIGLIT_FAIL);
+
+	return pass;
+}
+
+int main(int argc, char **argv)
+{
+	bool pass = true;
+
+	EGL_KHR_create_context_setup();
+
+	/* The EGL_KHR_create_context spec says:
+	 *
+	 *     "The defined versions of OpenGL at the time of writing are OpenGL
+	 *     1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 2.0, 2.1, 3.0, 3.1, 3.2, 4.0, 4.1,
+	 *     and 4.2. Feature deprecation was introduced with OpenGL 3.0, so
+	 *     forward-compatible contexts may only be requested for OpenGL 3.0
+	 *     and above. Thus, examples of invalid combinations of attributes
+	 *     include:
+	 *
+	 *       - Major version < 1 or > 4
+	 *       - Major version == 1 and minor version < 0 or > 5
+	 *       - Major version == 2 and minor version < 0 or > 1
+	 *       - Major version == 3 and minor version < 0 or > 2
+	 *       - Major version == 4 and minor version < 0 or > 2
+	 *       - Forward-compatible flag set and major version < 3
+	 */
+#if defined USE_OPENGL_ES1 || defined USE_OPENGL_ES2
+	eglBindAPI(EGL_OPENGL_ES_API);
+	pass = pass && try_version(-1, 0);
+	pass = pass && try_version(0, 0);
+	pass = pass && try_version(0, -1);
+	pass = pass && try_version(1, 2);
+	pass = pass && try_version(2, -1);
+	pass = pass && try_version(2, 1);
+#endif
+#ifdef USE_OPENGL
+	eglBindAPI(EGL_OPENGL_API);
+	pass = try_version(-1, 0) && pass;
+	pass = try_version(0, 0) && pass;
+	pass = try_version(1, -1) && pass;
+	pass = try_version(1, 6) && pass;
+	pass = try_version(2, -1) && pass;
+	pass = try_version(2, 2) && pass;
+	pass = try_version(3, -1) && pass;
+
+	/* There is no expectation that 3.4 will ever exist because it would
+	 * have to include functionality not in 4.0, and that would be weird.
+	 */
+	pass = try_version(3, 4) && pass;
+#endif
+
+	EGL_KHR_create_context_teardown();
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+
+	return EXIT_SUCCESS;
+}
-- 
1.7.8.6



More information about the Piglit mailing list