[Piglit] [PATCH 06/14] util: Remove unused piglit_present_results()
Kenneth Graunke
kenneth at whitecape.org
Tue Jun 12 17:23:45 PDT 2012
On 06/12/2012 04:02 PM, Chad Versace wrote:
> This was declared in piglit-framework.h, but never defined.
>
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
> ---
> tests/util/piglit-framework.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/util/piglit-framework.h b/tests/util/piglit-framework.h
> index a01b050..fcf38cf 100644
> --- a/tests/util/piglit-framework.h
> +++ b/tests/util/piglit-framework.h
> @@ -36,4 +36,3 @@ extern unsigned int piglit_winsys_fbo;
> extern enum piglit_result piglit_display(void);
> extern void piglit_init(int argc, char **argv);
> extern void piglit_present_results();
> -extern void piglit_set_default_fbo(unsigned int target);
Uh...what. :)
Your commit message says you're removing the unused function
piglit_present_results(). That function is used all over the place.
Your patch actually removes piglit_set_default_fbo(). Your analysis
seems to be incorrect and it seems reasonable to remove it. Just change
the commit message please :)
More information about the Piglit
mailing list