[Piglit] [PATCH 5/5] glx_ext_create_context_es2_profile: Verify that the invalid ES versions are rejected

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/12/2012 02:30 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> NVIDIA's closed-source driver fails this test.  GLXBadProfileARB is
> generated instead of BadMatch.  The specification isn't specific about
> what error should be generated, but I don't think GLXBadProfileARB is
> correct.  GLXBadProfileARB seems to only be generated in cases where
> the bit mask specified for GLX_CONTEXT_PROFILE_MASK_ARB is invalid.
> Cases where the GLX_CONTEXT_PROFILE_MASK_ARB is incongruous with the
> specified version either result in GLX_CONTEXT_PROFILE_MASK_ARB being
> ignored or BadMatch.
> 
> AMD's closed-source driver has not been tested.
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: James Jones <jajones at nvidia.com>
> ---
>  tests/all.tests                                    |    1 +
>  .../spec/glx_arb_create_context/CMakeLists.gl.txt  |    1 +
>  .../glx_arb_create_context/invalid-es-version.c    |  105 ++++++++++++++++++++
>  3 files changed, 107 insertions(+), 0 deletions(-)
>  create mode 100644 tests/spec/glx_arb_create_context/invalid-es-version.c

I really don't care if the error is GLXBadMatch or GLXBadProfile. Whatever
decision you and James arrive at, this test is

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJP2QY1AAoJEAIvNt057x8i7xEP/jLCRPqaPBHTnX+nEB1w5C9T
cZH6t1s2TnPU0VwgpLQPGLgKhSAocnX9hRgP3yoRNwovwCqGFyr4A4nLnDaTM9OS
iS9GgBijEIWIYn+eI68pjjj0TIDm+2DRxVHogQPIWm2nxOP/GagcomlincCjfxch
xrtocPz+IxMW3hOocJnsqCtiD00B6j+K05t84vXUabgOcOpmZgFM9G1jppLgWEC2
q56iOaK/x9nw/XJt38lULJauQzvTMV+bXO7rj7KRzAdPjQfF+oaUQkVvZZjVHxfN
uBJL1MptdMf7TPWMZqHXFUWTJjSZAp9ed9A/Lrmyz+oVW4w0WHbT102SBTWrVGuN
4peozPqTt3RQMJ+3ZuIU324oG6iRQEjDRzaplz/7mPxJ8rR8H3JeWISafCLYexO3
3NkI1unRTE+zqiqv2OILDra+S6QANPabpjvbfxTscumWbaNTWgObToEEhrJgliZZ
EpvrUHKNF7Kx6bRcaNh3yl8IyRjLlJFuSbTctND6xCd7h1NylooxEj1pdT4j5uwU
yajbW3gF+WNYNmLLOQXQT5e3rpqAwIvDonizPz6ofoYslOcaifFOLQ9qxgCy2s0+
xB1T9dNBxHn6CGlnQy83oMurjCDidFBx/o/IVUzXtJRYhgZCwYZ/stAgD/WGdEr4
vJt1pBeU3J78IxpN7jOU
=4DwK
-----END PGP SIGNATURE-----