[Piglit] [PATCH 1/7] GL_ARB_ubo/negative-bindbuffer-index: New test for API errors.

Eric Anholt eric at anholt.net
Mon Jun 18 18:27:29 PDT 2012


---
 tests/all.tests                                    |    1 +
 .../arb_uniform_buffer_object/CMakeLists.gl.txt    |    1 +
 .../negative-bindbuffer-index.c                    |   73 ++++++++++++++++++++
 3 files changed, 75 insertions(+)
 create mode 100644 tests/spec/arb_uniform_buffer_object/negative-bindbuffer-index.c

diff --git a/tests/all.tests b/tests/all.tests
index 17f5813..6cc7d5c 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1702,6 +1702,7 @@ arb_uniform_buffer_object['getuniformindices'] = concurrent_test('arb_uniform_bu
 arb_uniform_buffer_object['getuniformlocation'] = concurrent_test('arb_uniform_buffer_object-getuniformlocation')
 arb_uniform_buffer_object['layout-std140'] = concurrent_test('arb_uniform_buffer_object-layout-std140')
 arb_uniform_buffer_object['minmax'] = concurrent_test('arb_uniform_buffer_object-minmax')
+arb_uniform_buffer_object['negative-bindbuffer-index'] = concurrent_test('arb_uniform_buffer_object-negative-bindbuffer-index')
 
 ati_draw_buffers = Group()
 spec['ATI_draw_buffers'] = ati_draw_buffers
diff --git a/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt b/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
index 6d0a94f..900e683 100644
--- a/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
+++ b/tests/spec/arb_uniform_buffer_object/CMakeLists.gl.txt
@@ -15,5 +15,6 @@ add_executable (arb_uniform_buffer_object-getuniformindices getuniformindices.c)
 add_executable (arb_uniform_buffer_object-getuniformlocation getuniformlocation.c)
 add_executable (arb_uniform_buffer_object-layout-std140 layout-std140.c)
 add_executable (arb_uniform_buffer_object-minmax minmax.c)
+add_executable (arb_uniform_buffer_object-negative-bindbuffer-index negative-bindbuffer-index.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/arb_uniform_buffer_object/negative-bindbuffer-index.c b/tests/spec/arb_uniform_buffer_object/negative-bindbuffer-index.c
new file mode 100644
index 0000000..7b4744c
--- /dev/null
+++ b/tests/spec/arb_uniform_buffer_object/negative-bindbuffer-index.c
@@ -0,0 +1,73 @@
+/*
+ * Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/** @file negative-bindbuffer-index.c
+ *
+ * Tests for errors when binding higher than the maximum uniform
+ * buffer binding point.
+ */
+
+#include "piglit-util.h"
+
+int piglit_width = 100;
+int piglit_height = 100;
+int piglit_window_mode = GLUT_DOUBLE | GLUT_RGB | GLUT_ALPHA;
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	GLint max_bindings;
+	GLuint bo;
+
+	piglit_require_extension("GL_ARB_uniform_buffer_object");
+
+	glGenBuffers(1, &bo);
+	glBindBuffer(GL_UNIFORM_BUFFER, bo);
+	glBufferData(GL_UNIFORM_BUFFER, 1, NULL, GL_STATIC_READ);
+
+	glGetIntegerv(GL_MAX_UNIFORM_BUFFER_BINDINGS, &max_bindings);
+
+	/* From the GL_ARB_uniform_buffer_object spec:
+	 *
+	 *     "The error INVALID_VALUE is generated if <index> is
+	 *      greater than or equal to the value of
+	 *      MAX_UNIFORM_BUFFER_BINDINGS.
+	 */
+
+	glBindBufferBase(GL_UNIFORM_BUFFER, max_bindings, bo);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		pass = false;
+
+	glBindBufferRange(GL_UNIFORM_BUFFER, max_bindings, bo, 0, 1);
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
+		pass = false;
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
+
+enum piglit_result piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
-- 
1.7.10



More information about the Piglit mailing list